Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Custom Search API Connector #16

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Google Custom Search API Connector #16

merged 1 commit into from
Jul 25, 2023

Conversation

lunarserge
Copy link
Owner

@lunarserge lunarserge commented Jul 12, 2023

  • fsy.py: fs.py is now a pure module and fsy.py is launcher script for it - don't mix together since that is error-prone
  • src/facere_sensum/connectors/customsearch.py: implementatoin for Google search data connector (new)
  • src/facere_sensum/fs.py: minor fixes to support other changes
  • test/t_connectors/t_customsearch.py: unit test for Google search data connector
  • test/t_connectors/t_user.py: moved this logic to test/test.py to keep t_connectors folder only for actual tests
  • test/test.py: added invocation for connector unit tests, plus additional fixes to support other changes
  • test/input/customsearch.json: mock response from Google search API for testing purposes
  • examples/config_customsearch.json: example for users & also a test case
  • requirements.txt: added Google API lib dependency
  • lints.yaml: added fsy.py to testing

@lunarserge lunarserge requested a review from dbabokin July 12, 2023 22:43
Copy link
Collaborator

@dbabokin dbabokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbabokin dbabokin merged commit e578a25 into main Jul 25, 2023
6 checks passed
@dbabokin dbabokin deleted the customsearch branch July 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants