Skip to content

Conversation

@lumirlumir
Copy link
Owner

This pull request includes several changes to the configuration files and the addition of new linting rules. The most important changes involve adding new source files to the sync configuration, introducing a new textlint rule, and updating the lint-staged configuration.

Configuration updates:

Linting improvements:

Package configuration:

  • package.json: Added workspaces configuration and a new script for running textlint. [1] [2]

Copilot AI review requested due to automatic review settings March 17, 2025 08:19
@github-actions github-actions bot added 🏷️ scope: * Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes labels Mar 17, 2025
@github-actions
Copy link

Labels have been automatically applied based on the Conventional Commits specification.🏷️

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the project’s linting configuration by adding a textlint rule to disallow certain URIs and updating the lint-staged configuration for markdown files, as well as syncing these new configuration files.

  • Added a new textlint configuration in .textlintrc.js
  • Updated lint-staged.config.js to run both markdownlint and textlint on Markdown files
  • Included the new configuration files in the sync-client configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
.textlintrc.js Added a textlint rule to disallow links starting with "./"
lint-staged.config.js Updated Markdown file linting to run both markdownlint and textlint
.github/sync-client.yml Synchronized new configuration files for textlint and lint-staged
Comments suppressed due to low confidence (1)

lint-staged.config.js:7

  • Ensure that lint-staged supports an array of commands for '*.md' files. If not, consider chaining the commands into a single shell command.
  '*.md': ['npx markdownlint', 'npx textlint -f pretty-error'],

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (6f5413b) to head (3138aa9).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          11       12    +1     
  Lines        1016     1025    +9     
=======================================
+ Hits         1012     1021    +9     
  Misses          4        4           
Files with missing lines Coverage Δ
.textlintrc.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5413b...3138aa9. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lumirlumir lumirlumir merged commit 84cc065 into main Mar 17, 2025
8 checks passed
@lumirlumir lumirlumir deleted the chore-add-textlint-config-and-integrate-with-lint-staged branch March 17, 2025 08:20
lumirlumir added a commit that referenced this pull request Mar 18, 2025
…ch`) (#200)

## Release Information: `v1.0.9`

New release of `lumirlumir/npm-textlint-rule-allowed-uris` has arrived!
:tada:

This PR bumps the package versions from `v1.0.8` to `v1.0.9` (`patch`).

See
[Actions](https://github.com/lumirlumir/npm-textlint-rule-allowed-uris/actions/runs/13927306027)
for more details.

| Info        | Value                      |
| ----------- | -------------------------- |
| Repository  | `lumirlumir/npm-textlint-rule-allowed-uris` |
| SEMVER      | `patch`     |
| Pre ID      | `canary`      |
| Short SHA   | f11ce22       |
| Old Version | `v1.0.8`  |
| New Version | `v1.0.9`  |

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### 🧰 Chores
* chore(sync-server): update `dependabot.yml` by @lumirlumir in
#167
* chore(*): add `provenance` to `publishConfig` in `package.json` by
@lumirlumir in
#169
* chore(sync-server): update `publish.yml` and `.prettierignore` by
@lumirlumir in
#171
* chore(sync-server): update `.editorconfig` `max_line_length` to
`100000` by @lumirlumir in
#181
* chore(sync-server): update `.markdownlint.json` by @lumirlumir in
#186
* chore(*): install `textlint` as deps-dev and delete unnecessary files
by @lumirlumir in
#190
* chore(*): drop `mocha` and replace it with node built-in test runner
by @lumirlumir in
#192
* chore(*): create `CONTRIBUTING.md` and update ESLint config file by
@lumirlumir in
#194
* chore(*): add textlint configuration and integrate with lint-staged by
@lumirlumir in
#197
### 🔄 Continuous Integrations
* ci(sync-server): add permissions to read contents in `lint.yml` and
`test.yml` workflows by @lumirlumir in
#179
* ci(sync-server): add permissions to `pull-request.yml` and
`sync-client.yml` by @lumirlumir in
#180
* ci(*): drop `bump.yml` and create `version-multirepo.yml` by
@lumirlumir in
#198
* ci(*): create `release.yml` by @lumirlumir in
#199
### 📝 Documentation
* docs(*): create `SECURITY.md` by @lumirlumir in
#193
* docs(*): update `README.md` and `config.yml` by @lumirlumir in
#195
### ♻️ Code Refactoring
* refactor(*): update module imports to use `node:` prefix for
consistency by @lumirlumir in
#173
* refactor(*): create `src/types.js` by @lumirlumir in
#174
* refactor(*): rename `src/types.js` to `src/types/index.js` by
@lumirlumir in
#175
* refactor(*): restructure `theme` utilities and update usage in files
by @lumirlumir in
#176
* refactor(*): rename and refactor `UriTypes` class by @lumirlumir in
#177
* refactor(*): restructure directories and update comments by
@lumirlumir in
#191
### ⬆️ Dependency Updates
* chore(deps-dev): bump eslint from 9.20.1 to 9.21.0 by @dependabot in
#165
* chore(deps-dev): bump prettier from 3.5.1 to 3.5.2 by @dependabot in
#166
* chore(deps): bump axios from 1.7.9 to 1.8.1 by @dependabot in
#168
* chore(deps): bump undici from 6.19.7 to 6.21.1 in the npm_and_yarn
group across 1 directory by @dependabot in
#170
* chore(deps-dev): bump prettier from 3.5.2 to 3.5.3 by @dependabot in
#172
* chore(deps-dev): bump eslint from 9.21.0 to 9.22.0 by @dependabot in
#182
* chore(deps): bump axios from 1.8.1 to 1.8.2 by @dependabot in
#183
* chore(deps-dev): bump @babel/core from 7.26.9 to 7.26.10 in the babel
group across 1 directory by @dependabot in
#184
* chore(deps-dev): bump textlint-tester from 14.4.2 to 14.5.0 by
@dependabot in
#185
* chore(deps-dev): bump eslint-config-bananass from 0.0.5 to 0.0.6 in
the bananass group across 1 directory by @dependabot in
#187
* chore(deps): bump axios from 1.8.2 to 1.8.3 by @dependabot in
#188
* chore(deps-dev): bump lint-staged from 15.4.3 to 15.5.0 by @dependabot
in #189


**Full Changelog**:
v1.0.8...v1.0.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ scope: * Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: chore Auto-generated label based on Conventional Commits specification for GitHub release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants