Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 2, 2021

This renames all the listed requirements from #78.
Please try out if it breaks something for you.

@ghost ghost requested review from asver12 and keli95566 February 2, 2021 09:48
@codecov-io
Copy link

Codecov Report

Merging #84 (8990075) into master (b8b3596) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   30.95%   30.95%           
=======================================
  Files         106      106           
  Lines        1919     1919           
  Branches      317      317           
=======================================
  Hits          594      594           
  Misses       1173     1173           
  Partials      152      152           
Flag Coverage Δ
unittests 30.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/Facet/Facet.js 7.69% <ø> (ø)
src/components/Facet/FacetContainer.js 5.40% <0.00%> (ø)
src/components/StandardPlot/StandardPlot.js 1.25% <0.00%> (ø)
...nts/StandardSpecification/StandardSpecification.js 12.50% <ø> (ø)
src/configs/specificationFacetsConfig.js 100.00% <ø> (ø)
src/states/standardplots/actions.js 0.00% <0.00%> (ø)
src/states/standardplots/utils.js 10.00% <0.00%> (ø)
src/states/standardspecifications/actions.js 92.85% <ø> (ø)
src/states/standardspecifications/testData.js 100.00% <ø> (ø)
src/utils/plotData.js 10.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b3596...8990075. Read the comment docs.

@ghost ghost linked an issue Feb 2, 2021 that may be closed by this pull request
@ghost ghost mentioned this pull request Feb 23, 2021
@ghost ghost closed this Feb 23, 2021
@ghost
Copy link
Author

ghost commented Feb 23, 2021

Obsolete because of #87

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix typos / terms / icons in UI

3 participants