Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUM-807] Claim & Compound #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[LUM-807] Claim & Compound #52

wants to merge 6 commits into from

Conversation

Ricardo-Remy
Copy link
Contributor

@Ricardo-Remy Ricardo-Remy commented Sep 7, 2023 •
edited
Loading

Introduction

This feature improves the existing option to auto compound for someone who wins a prize by directly passing the option to the MsgClaimPrize.

Changes include

  • Add option to MsgClaimPrize to autocompound
  • Add option to MsgClaimPrize to sponsor the new deposit
  • Add deposit_origin flag to know from which source the deposit came (direct or autocompound)

Completion checklist

  • Unittests pass
  • Devnet upgrade & tests

@Ricardo-Remy Ricardo-Remy changed the title WIP - [LUM-807] - Claim & Compound [LUM-807] - Claim & Compound Sep 7, 2023
@Ricardo-Remy Ricardo-Remy marked this pull request as ready for review September 7, 2023 10:14
Segfaultd
Segfaultd requested changes Sep 7, 2023
View reviewed changes
x/millions/keeper/keeper_deposit.go Outdated Show resolved Hide resolved
x/millions/migrations/v161/store.go Outdated Show resolved Hide resolved
x/millions/types/errors.go Outdated Show resolved Hide resolved
x/millions/keeper/msg_server_prize.go Outdated Show resolved Hide resolved
lebascou
lebascou requested changes Sep 8, 2023
View reviewed changes
proto/lum/network/millions/deposit.proto Outdated Show resolved Hide resolved
x/millions/types/events.go Outdated Show resolved Hide resolved
x/millions/keeper/keeper_deposit.go Show resolved Hide resolved
x/millions/keeper/msg_server_prize.go Outdated Show resolved Hide resolved
@lebascou lebascou added the DO NOT MERGE ⏲️ Do not merge unless decided otherwise label Nov 15, 2023
@lebascou lebascou changed the title [LUM-807] - Claim & Compound [LUM-807] Claim & Compound Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebascou lebascou lebascou requested changes

@Segfaultd Segfaultd Segfaultd approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE ⏲️ Do not merge unless decided otherwise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ricardo-Remy @lebascou @Segfaultd