Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Upgrade v1.5 #38

Merged
merged 127 commits into from
Jul 14, 2023
Merged

Core Upgrade v1.5 #38

merged 127 commits into from
Jul 14, 2023

Conversation

lebascou
Copy link
Contributor

@lebascou lebascou commented Jun 14, 2023

Changelog

  • PR#25: Handle pool paused state
    • Properly handle all pool states (especially Paused state to prevent Draws from happening)
    • Pool state update via governance proposal
  • PR#27: Allow native zone toAddress
    • Allow for withdrawals to go directly on a remote zone wallet (instead of going back to the Lum Network)
  • PR#28: Upgrade to Cosmos SDK v0.47.3
    • Upgrade to Cosmos SDK v0.47
    • Migration to CometBFT
    • Upgrade to Ibc-go v7
    • Protobuf clean up and re-generation
  • PR#29: Handle re-delegate assets from a disabled validator
    • Evenly redelegate assets from disabled validators (not part of the active set anymore) upon Pool update proposal success
  • PR#32: Add msg to edit a deposit
    • Edit winner address
    • Edit sponsor mode
  • PR#40: DFract - move from Proposal to Tx based minting
    • Change WithdrawAndMint proposal into an UpdateParams proposal with an UpdateParams handler
    • Add a new tx based message WithdrawAndMint
  • PR#41: Fix draw prizes fees implementation
    • Migration to add uncollected fees to the PrizePool not included in this fixe - this should be evaluated at a later time due to the low amount which has not been collected.
  • PR#44: Prize uniqueness

Segfaultd and others added 12 commits June 29, 2023 12:20
[LUM-710] - Upgrade to Cosmos SDK v0.47.3
* rc/v1.5: (60 commits)
  Fix consensus module registration
  Migrate consensus params and properly register keeper
  Add format for import ordering
  Add new NewMsgServerImpl for beam module
  Add RegisterMsgServer for RegisterServices in x/airdrop/module.go
  Add RegisterMsgServer for RegisterServices in x/millions/module.go
  Formatting
  Fixed ICA callbacks handlers registration
  Fix usage between port owner name and port ID
  Fixed ignite gov module config
  Add comment
  IBC Stack revamp
  Redundant implementation
  Install more dependencies
  Remove capabilities for ownership transfer
  Unused ClaimCapability anymore
  Use store key for consistence
  Move back proto to their original path for backward compatibility
  Revert "Fix codecs registration"
  Fix codecs registration
  ...
* rc/v1.5: (58 commits)
  Fix consensus module registration
  Migrate consensus params and properly register keeper
  Add format for import ordering
  Add new NewMsgServerImpl for beam module
  Add RegisterMsgServer for RegisterServices in x/airdrop/module.go
  Add RegisterMsgServer for RegisterServices in x/millions/module.go
  Formatting
  Fixed ICA callbacks handlers registration
  Fix usage between port owner name and port ID
  Fixed ignite gov module config
  Add comment
  IBC Stack revamp
  Redundant implementation
  Install more dependencies
  Remove capabilities for ownership transfer
  Unused ClaimCapability anymore
  Use store key for consistence
  Move back proto to their original path for backward compatibility
  Revert "Fix codecs registration"
  Fix codecs registration
  ...
[LUM-570] - Add msg to edit a deposit
* rc/v1.5:
  Fix import ordering
  Update metadata for EditDeposit and ValidateBasic static check
  Fix linting errors
  Fix format check
  Add edit deposit feature
[LUM-745] - Fix draw prizes fees implementation
[LUM-583] - Handle re-delegate assets from a disabled validator
@lebascou lebascou marked this pull request as ready for review June 29, 2023 15:26
@lebascou lebascou changed the title WIP - Core Upgrade v1.5 Core Upgrade v1.5 Jun 29, 2023
@lebascou lebascou requested a review from Segfaultd June 29, 2023 15:26
@lebascou
Copy link
Contributor Author

@Segfaultd release branch ready for advanced testing !
Please keep in mind the comment regarding Cosmos Millions fees migration (we can probably automated the computation of the amount but I am worried about the behaviour of such automated computation..)

Ricardo-Remy and others added 12 commits June 29, 2023 20:52
* Added store migrator for port IDs

* Fix imports

* Fix comment
[LUM-739] - DFract -> Move from Proposal to Tx based minting
* Fixed OnExecuteDrawCompleted naming

* addedPrizeWinners to filter already added winners

* Update keeper_draw.go

* Revert to prev commit

* Cosmetic improvement

* Prize batch uniqueness basics

* Add prize computation dedicated to strat with at least one unique prizew

* Add dedicated unique win tests

---------

Co-authored-by: RLM <[email protected]>
Co-authored-by: Fabrice Bascoulergue <[email protected]>
@Segfaultd Segfaultd merged commit 557b481 into master Jul 14, 2023
5 checks passed
@lebascou lebascou deleted the rc/v1.5 branch November 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants