refactor: update universalReceiver event in lsp0 & lsp9

lukso-network · Oct 27, 2023 · dc75b7a · dc75b7a
1 parent 1653101
commit dc75b7a
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/contracts/LSP0ERC725Account/LSP0ERC725AccountCore.sol b/contracts/LSP0ERC725Account/LSP0ERC725AccountCore.sol
@@ -120,7 +120,7 @@ abstract contract LSP0ERC725AccountCore is
      *
      * 2. If the data sent to this function is of length less than 4 bytes (not a function selector), return.
      *
-     * @custom:events {UniversalReceiver} event when receiving native tokens.
+     * @custom:events {UniversalReceiver} event when receiving native tokens and extension function selector is not found or not payable.
      */
     // solhint-disable-next-line no-complex-fallback
     fallback(
@@ -198,7 +198,7 @@ abstract contract LSP0ERC725AccountCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP0_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }
@@ -262,7 +262,7 @@ abstract contract LSP0ERC725AccountCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP0_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }
@@ -321,7 +321,7 @@ abstract contract LSP0ERC725AccountCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP0_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }
@@ -364,7 +364,7 @@ abstract contract LSP0ERC725AccountCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP0_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }

diff --git a/contracts/LSP9Vault/LSP9VaultCore.sol b/contracts/LSP9Vault/LSP9VaultCore.sol
@@ -122,7 +122,7 @@ contract LSP9VaultCore is
      *
      * 2. If the data sent to this function is of length less than 4 bytes (not a function selector), return.
      *
-     * @custom:events {UniversalReceiver} event when receiving native tokens.
+     * @custom:events {UniversalReceiver} event when receiving native tokens and extension function selector is not found or not payable.
      */
     // solhint-disable-next-line no-complex-fallback
     fallback(
@@ -202,7 +202,7 @@ contract LSP9VaultCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP9_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }
@@ -237,7 +237,7 @@ contract LSP9VaultCore is
                 msg.sender,
                 msg.value,
                 _TYPEID_LSP9_VALUE_RECEIVED,
-                "",
+                abi.encodePacked(msg.sig),
                 ""
             );
         }

diff --git a/docs/contracts/LSP0ERC725Account/LSP0ERC725Account.md b/docs/contracts/LSP0ERC725Account/LSP0ERC725Account.md
@@ -110,7 +110,7 @@ This function is executed when:
 
 **Emitted events:**
 
-- [`UniversalReceiver`](#universalreceiver) event when receiving native tokens.
+- [`UniversalReceiver`](#universalreceiver) event when receiving native tokens and extension function selector is not found or not payable.
 
 </blockquote>
 

diff --git a/docs/contracts/LSP9Vault/LSP9Vault.md b/docs/contracts/LSP9Vault/LSP9Vault.md
@@ -96,7 +96,7 @@ This function is executed when:
 
 **Emitted events:**
 
-- [`UniversalReceiver`](#universalreceiver) event when receiving native tokens.
+- [`UniversalReceiver`](#universalreceiver) event when receiving native tokens and extension function selector is not found or not payable.
 
 </blockquote>
 

diff --git a/tests/LSP9Vault/LSP9Vault.behaviour.ts b/tests/LSP9Vault/LSP9Vault.behaviour.ts
@@ -801,7 +801,7 @@ export const shouldBehaveLikeLSP9 = (
             context.deployParams.newOwner,
             msgValue,
             LSP1_TYPE_IDS.LSP9ValueReceived,
-            '0x',
+            context.universalProfile.interface.getSighash('executeBatch'),
             '0x',
           );
       });

diff --git a/tests/UniversalProfile.behaviour.ts b/tests/UniversalProfile.behaviour.ts
@@ -289,7 +289,7 @@ export const shouldBehaveLikeLSP3 = (
               context.accounts[0].address,
               msgValue,
               LSP1_TYPE_IDS.LSP0ValueReceived,
-              '0x',
+              context.universalProfile.interface.getSighash('setData'),
               '0x',
             );
 
@@ -314,7 +314,7 @@ export const shouldBehaveLikeLSP3 = (
               context.accounts[0].address,
               msgValue,
               LSP1_TYPE_IDS.LSP0ValueReceived,
-              '0x',
+              context.universalProfile.interface.getSighash('setDataBatch'),
               '0x',
             );
 
@@ -429,7 +429,7 @@ export const shouldBehaveLikeLSP3 = (
             context.deployParams.owner.address,
             msgValue,
             LSP1_TYPE_IDS.LSP0ValueReceived,
-            '0x',
+            context.universalProfile.interface.getSighash('executeBatch'),
             '0x',
           );
       });