1.19 Port #36
1.19 Port #36
Conversation
There was a problem hiding this comment.
Thank you for submitting this PR! I have gone through the changes and they mostly look good to me. I noted a few minor things that need fixing in the comments. What is also missing is appropriate changes to the GitHub CI workflows. However, I can do that myself.
panelstudio-mc19/src/main/java/com/lukflug/panelstudio/mc17/package-info.java
Outdated
Show resolved
Hide resolved
panelstudio-mc19/src/main/java/com/lukflug/panelstudio/mc17/package-info.java
Outdated
Show resolved
Hide resolved
panelstudio-mc19/src/main/java/com/lukflug/panelstudio/mc17/MinecraftGUI.java
Outdated
Show resolved
Hide resolved
|
Updated the requested changes! Sorry for the mistakes I forgot to push my local version which fixed the variables and the description :' Sadly I have never worked with the github CI which is why I can't help with that. But if I can find a quick guide/I get a quick explanation I would not mind changing the CI workflows. |
|
I think I figured it out :' hope the CI update works. it failed because the MC1.19 mod isnt available to compile so I think it will work once its in the repo |
|
Thank you for your changes! I'll merge it, and test and fix some things before doing a release. |
Ported the mod to 1.19 and updated the example mod.