feat(security): add approved rooms/users/domains as env variables

[luketainton]

Resolves #276

[luketainton]

Google Gemini AI Review

Decision: Reject
Change Score: 50%

• Issue: Importing untested module

  • The code imports app.utils.helpers, but there are no tests for this module.

• Issue: approved_users in tests

  • The test case for config contains the key approved_users, but this key is not present in the config class.

• Issue: version in tests

  • The test case for config contains the key version, but this key is not present in the config class.

• Issue: .env settings not used

  • The test.sh script loads .env instead of .env.test. Consequently, the test environment is not properly configured.

• Issue: Pytest-related dependency missing

  • pytest-monkeypatch is required for testing, but it is not currently installed.

Suggestions:

• Add tests for app.utils.helpers.
• Remove approved_users and version from tests/test_config.py.
• Update test.sh to load .env.test.
• Install pytest-monkeypatch.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud