Skip to content

[RISCV] Reject i1 vp.load/vp.store in cost model (remove LV-side workaround) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

[RISCV] Reject i1 vp.load/vp.store in cost model (remove LV-side workaround) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d53907
[RISCV] Add VP_LOAD/VP_STORE support for mask (i1) vector types
Copilot May 28, 2026
71f1279
Prevent vp.load/vp.store of i1 types in optimizeMaskToEVL
Copilot May 28, 2026
d3666c3
Remove vp.load/vp.store RISCV lowering changes; add crash-fix test
Copilot May 28, 2026
c0ce65e
[RISCV] Reject i1 vp.load/store in cost model
Copilot May 28, 2026
7c1ef91
RISCV: drop redundant i1 vp.load/store mem-cost guard
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,14 @@ RISCVTTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
TTI::TargetCostKind CostKind) const {
auto *RetTy = ICA.getReturnType();
switch (ICA.getID()) {
case Intrinsic::vp_load:
case Intrinsic::vp_store: {
Type *DataTy = ICA.getID() == Intrinsic::vp_store ? ICA.getArgTypes()[0]
: ICA.getReturnType();
if (DataTy && DataTy->isIntOrIntVectorTy(1))
return InstructionCost::getInvalid();
break;
}
case Intrinsic::lrint:
case Intrinsic::llrint:
case Intrinsic::lround:
Expand Down
11 changes: 11 additions & 0 deletions llvm/test/Analysis/CostModel/RISCV/vp-intrinsics.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,17 @@ define void @store() {
ret void
}

define void @i1_vp_memory() {
; CHECK-LABEL: 'i1_vp_memory'
; CHECK-NEXT: Cost Model: Invalid cost for instruction: %l = call <vscale x 16 x i1> @llvm.vp.load.nxv16i1.p0(ptr undef, <vscale x 16 x i1> undef, i32 undef)
; CHECK-NEXT: Cost Model: Invalid cost for instruction: call void @llvm.vp.store.nxv16i1.p0(<vscale x 16 x i1> undef, ptr undef, <vscale x 16 x i1> undef, i32 undef)
; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: ret void
;
%l = call <vscale x 16 x i1> @llvm.vp.load.nxv16i1.p0(ptr undef, <vscale x 16 x i1> undef, i32 undef)
call void @llvm.vp.store.nxv16i1.p0(<vscale x 16 x i1> undef, ptr undef, <vscale x 16 x i1> undef, i32 undef)
ret void
}

define void @gather() {
; ARGBASED-LABEL: 'gather'
; ARGBASED-NEXT: Cost Model: Found an estimated cost of 2 for instruction: %1 = call <2 x i8> @llvm.vp.gather.v2i8.v2p0(<2 x ptr> poison, <2 x i1> poison, i32 poison)
Expand Down