Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollify doesn't ignore currentHash anymore #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HugoHeneault
Copy link

If you loaded your page with an hash to an existing ID, scrollify just ignored it and stopped the default browser behavior.

For example, mysite.com/#test became mysite.com/#home (where home is the first section).

Now it's fixed.

@lukehaas
Copy link
Owner

This would mean that the page could load half way scrolled between two sections.
This isn't really the user experience that Scrollify is intended for.

@HugoHeneault
Copy link
Author

In my case, I want to use scrollify as it is intended, but... I also want to create direct links to some parts of my page.

I don't think this breaks Scrollify's UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants