-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A test that exits early should fail #207
Conversation
Fixes lukeed#206 Also fixes the case where a test calls process.exit(0) itself, as that's essentially the same thing.
I just ran into this issue as well, so regardless of the solution it would be nice to see this fixed. |
The nice part about this solution is that it also catches the case where you call into a library and that library calls This isn't in tension with a solution that prevents tests from being GC'd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! few minor things, thanks!
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 89.48% 89.13% -0.36%
==========================================
Files 4 3 -1
Lines 333 313 -20
==========================================
- Hits 298 279 -19
+ Misses 35 34 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #206
Also fixes the case where a test calls process.exit(0) itself, as that's essentially the same thing.