False positives

[sapegin]

I found a few false positive cases, where the library replaces imports where it shouldn't. But I'm not sure trying to fix that will be in the scope of the library. Probably I'll just allow imports only at the beginning of the file — they supposed to be hoisted anyway.

const line = "import foo from 'foo'"
const line = 'import foo from "foo"'
const line = `import foo from 'foo'`

<p>import foo from 'foo'</p>

[lukeed]

Hmm we can make it something like ^[\s|\n]import, right? Plus the "is top of file" case.

[sapegin]

Nah, imagine a multiline string with JS code ;-) We'll never fix all the issues here, and likely make many new ones ;-)

I think we should just document it, and I'm going to try to use AST to find actual import positions and transpile them in place with rewrite-imports.

[lukeed]

Lol okay, pick your battles I guess 😆