Add --mjs option to generate ESM migration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 50.00% // Head: 48.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 50.00% 48.82% -1.18%
==========================================
Files 2 2
Lines 206 213 +7
==========================================
+ Hits 103 104 +1
- Misses 103 109 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lukeed
reviewed
Oct 10, 2022
lukeed
reviewed
Oct 10, 2022
lukeed
reviewed
Oct 10, 2022
lukeed
reviewed
Oct 10, 2022
Merged
|
Glad to help, thanks for the merge! 🙌 Opened #32 for the typo in the options property in the condition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @lukeed 👋 Hope that you are well!
A new bootcamp cohort of ours is learning how to use Ley, and I wanted to teach them to use ESM in their migration files, but
ley newdidn't support it.What do you think of this
--mjsoption in this PR? If you are open to it, I can write a docs section for it too. (an alternative name for this flag could be--esm, but that wouldn't indicate that it will also use.mjsfiles)This also avoids the tab vs spaces thing by removing any type of indentation from this file.
Closes #21