Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TS Support #40

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Updated TS Support #40

merged 5 commits into from
Oct 25, 2023

Conversation

Akkuma
Copy link
Contributor

@Akkuma Akkuma commented Oct 24, 2023

The current package.json doesn't seem to work with the latest TS versions. This resolves those issues.

There are types at '/node_modules/dset/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'dset' library may need to update its package.json or typings.ts(7016)
@lukeed
Copy link
Owner

lukeed commented Oct 24, 2023

Thanks for this. Each condition doesnt need a separate types condition though since theyre not loading different dts files for ESM vs CJS

Can you please update each entry to be this shape:

{
  "types": "...",
  "import": "...",
  "require": "..."
}

@Akkuma
Copy link
Contributor Author

Akkuma commented Oct 24, 2023

Thanks for this. Each condition doesnt need a separate types condition though since theyre not loading different dts files for ESM vs CJS

Can you please update each entry to be this shape:

{
  "types": "...",
  "import": "...",
  "require": "..."
}

Sure thing I'll get this squared away tonight and update the PR tomorrow.

@Akkuma
Copy link
Contributor Author

Akkuma commented Oct 25, 2023

@lukeed got this updated now.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@lukeed lukeed merged commit aca90fb into lukeed:master Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants