Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the readme’s first link to benchmarks #82

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

acusti
Copy link
Contributor

@acusti acusti commented Oct 20, 2023

for some reason, the faster link at the top of the README in the description block gets interpreted as pointing to github.com/bench. making it a fully relative link (no leading slash) fixes that issue.

here’s a link to the readme file showing the bad link URL resolution on master: https://github.com/lukeed/clsx/blob/master/readme.md

and here’s a link to the readme file in the same GitHub view but from this branch: https://github.com/acusti/clsx/blob/patch-1/readme.md

oh yes, and thank you so much for this package! it’s such a wonderful asset for the community.

@acusti acusti changed the title chore: Fix the readme’s first link to benchmarks Fix the readme’s first link to benchmarks Oct 20, 2023
@lukeed
Copy link
Owner

lukeed commented Oct 20, 2023

Oh bummer. This might have been an unintended change in the last batch of GH readme updates

thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants