Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS2345 fix #6

Merged
merged 1 commit into from
Feb 3, 2019
Merged

TS2345 fix #6

merged 1 commit into from
Feb 3, 2019

Conversation

chulanovskyi
Copy link
Contributor

Hi! The problem can be described with a single screenshot :)

example

lukeed
lukeed approved these changes Feb 3, 2019
View reviewed changes
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you 🙌 That's definitely a problem & should be allowed.

At this point, shouldn't it just be any or any[]? I don't TS so I'm not sure what the implications/trade-offs are there.

Thanks again~

@lukeed lukeed merged commit af56fa4 into lukeed:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chulanovskyi @lukeed