-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @title keyword annotation #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there DominykasValutis 👋
Thank you and congrats 🎉 for opening your first PR on this project.✨
We will review the following PR soon! 👀
Sorry for the delay. Could you add a test to make sure this doesn´t break accidentally? |
@WoH could you guide me for which component you want me to add test, cannot find any previous test for validatorUtils.ts file |
There are no tests for that file explicitly, but you can add an annotation in the test fixtures and add an assertion for OpenAPI V2 / V3 here: https://github.com/lukeautry/tsoa/tree/master/tests%2Funit%2Fswagger schemaDetails(3).ts |
@WoH added unit test |
I think still missing OpenAPI 2's unit test. |
Not sure if annotations are tested in OpenAPI V2, could you point me where should I add it if I'm wrong |
@WoH @jackey8616 could you reply to the previous comment, thank you! |
Sorry for the late reply, |
@jackey8616 @WoH added unit tests for OpenAPI V2 |
@jackey8616 @WoH when this can be merged? |
30cc104
to
82b61ec
Compare
All Submissions:
Closing issues
Put
closes #1656
If this is a new feature submission:
Potential Problems With The Approach
Test plan