Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced the deprecated parent.module for the recommended require.main #1108

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

jpmtrabbold
Copy link

@jpmtrabbold jpmtrabbold commented Oct 10, 2021

closes #1069

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests? Nope - I not sure how I would go about to write unit tests for this kind of bugfix...
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

@WoH WoH merged commit 2ca75b6 into lukeautry:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatibility with esbuild
3 participants