-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 9 support #304
base: master
Are you sure you want to change the base?
Angular 9 support #304
Conversation
https://github.com/kolkov/ngx-gallery try this please. |
Can't waiting to merge these changes into master. |
Until that I would recommend to Use Andrey Kolkov library is fully
compatible with ngx-gallery and works with Angular 9.
…On Mon, 24 Feb 2020, 09:10 Fahd Allebdi, ***@***.***> wrote:
Can't waiting to merge these changes into master.
Thank you @nOstap <https://github.com/nOstap>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#304?email_source=notifications&email_token=AFROA2DEUEMSO6EESKPVDXTREOFGTA5CNFSM4KTAR4L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXCETA#issuecomment-590225996>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFROA2FHELV6QCWV747QA33REOFGTANCNFSM4KTAR4LQ>
.
|
Please merge the changes. |
Would be great to have this merged :) |
Until that I would recommend to Use Andrey Kolkov library is fully
compatible with ngx-gallery and works with Angular 9.
…On Thu, 19 Mar 2020, 18:24 Eloy Roura, ***@***.***> wrote:
Would be great to have this merged :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#304 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFROA2A7RAPLFPQEFRME3M3RIJPMDANCNFSM4KTAR4LQ>
.
|
@lukasz-galka can you merge this PR which will resolve render error. This will help us to migrate our application to angular 9 |
For anyone who waits for this to be merged, I would recommend to Use Andrey Kolkov library is fully compatible with ngx-gallery and works with Angular 9. https://github.com/kolkov/ngx-gallery |
This seems like a great component and great effort from the owner and contributors. Github is great and I love it when developers can contribute. HOWEVER, it is kind of disheartening when owners cannot anymore follow up on contributions and get the time to merge. What can you do... life... :) Mostly I noticed this is because the owners will get busy with their work/life. Happened to me too. But yes it would be great for this to be merged. :) |
This pull request removes old Renderer references which are no longer supported by Angular 9.