Unicode endpoints #33
Comments
|
@Eremiell Thanks for making me aware of this problem. As far as I know, FontCustom doesn't offer any way to configure this, so we may need to switch to resolve it. The FontCustom project appears to be quite dead anyway, so I'm open to alternatives. |
Closed
Finii
added a commit
to Finii/font-logos
that referenced
this issue
Jan 26, 2022
[why] When codepoints are changed for the individual logos that should be a deliberate decision. [how] We have now a dedicated file for the codepoint to logo mapping. That will be used for the font generation: `glyphs.json`. If new logos show up or exisiting ones are deleted this will change that dedicated file when `compile.sh` is called and what happened is clearly visible in the changed git status. People who add / remove a logo have to run `compile.sh` and afterwards review the changes in the `glyphs.json` file and include that changes in their commit. [how] This is only slightly different to the formerly used solution: Keep the `.fontcustom-manifest.json` in git. But that has been removed with commit f161cf6 for some reason. Maybe because that file is hidden, which is not so nice. This PR just preserves the "glyphs" section of the manifest and extracts it into a dedicated file, that can be added and reviewed. [note] Glyph codepoints reverted back to f161cf6^ i.e. v0.17. Fixes lukas-w#33 Fixes lukas-w#72 Signed-off-by: Fini Jastrow <[email protected]>
Finii
added a commit
to Finii/font-logos
that referenced
this issue
Jan 26, 2022
[why] When codepoints are changed for the individual logos that should be a deliberate decision. [how] We have now a dedicated file for the codepoint to logo mapping. That will be used for the font generation: `glyphs.json`. If new logos show up or exisiting ones are deleted this will change that dedicated file when `compile.sh` is called and what happened is clearly visible in the changed git status. People who add / remove a logo have to run `compile.sh` and afterwards review the changes in the `glyphs.json` file and include that changes in their commit. [note] This is only slightly different to the formerly used solution: Keep the `.fontcustom-manifest.json` in git. But that has been removed with commit f161cf6 for some reason. Maybe because that file is hidden, which is not so nice. This PR just preserves the "glyphs" section of the manifest and extracts it into a dedicated file, that can be added and reviewed. [note] Glyph codepoints reverted back to `f161cf6^` i.e. 12f3783 (a.k.a. v0.17) Fixes lukas-w#33 Fixes lukas-w#72 Signed-off-by: Fini Jastrow <[email protected]>
|
Apologies @Finii, I didn't mean to ignore you, just haven't had much time & energy to spare recently. I'll get back to you. |
|
No apologies needed! Thank you for working on this project despite short time (I know that situation ;-). |
|
Fixed in |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Btw, it might be a good idea to have some chat with people over at https://github.com/ryanoasis/nerd-fonts about endpoint (unicode code) allocation. They move the whole range some 0x200 endpoints up because it clashes with other common icon fonts.
ryanoasis/nerd-fonts#138
https://github.com/ryanoasis/nerd-fonts/wiki/Codepoint-Conflicts#font-linux--font-awesome
Agreeing on some allocation that doesn't clash with anything, so the merger goes clean and the codes match in clean font-linux and in nerd-fonts might be beneficial.
The text was updated successfully, but these errors were encountered: