-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Twill + add Feature Flags + basic Pages Capsule + basic Transformers #4
Open
antonioribeiro
wants to merge
20
commits into
luislavena:main
Choose a base branch
from
antonioribeiro:twill-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislavena
reviewed
Jul 7, 2022
antonioribeiro
force-pushed
the
twill-settings
branch
2 times, most recently
from
July 11, 2022 12:56
90bb454
to
1ad3c16
Compare
antonioribeiro
changed the title
WIP: Configure Twill + add Feature Flags + basic Pages Capsule + basic Transformers
Configure Twill + add Feature Flags + basic Pages Capsule + basic Transformers
Jul 18, 2022
Avoid using Laravel as `APP_NAME` to avoid confusion ;-)
Make sure Twill bundled assets are updated after `composer install`, to ensure admin interface (CSS/JS).
luislavena
force-pushed
the
twill-settings
branch
from
July 18, 2022 14:55
fd74803
to
d63191d
Compare
luislavena
force-pushed
the
twill-settings
branch
from
July 19, 2022 09:10
d060344
to
a0ad285
Compare
luislavena
reviewed
Jul 19, 2022
Comment on lines
+15
to
+24
'config' => [ | ||
'title' => 'Configuration', | ||
'route' => 'admin.config.featureFlags.index', | ||
'primary_navigation' => [ | ||
'featureFlags' => [ | ||
'title' => 'Feature Flags', | ||
'route' => 'admin.config.featureFlags.index', | ||
], | ||
], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed where to place these settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, just for everyone to know that this is being done.