Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listeners and ensure memory cleanup in CSV processing #300

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ludeknovy
Copy link
Owner

@ludeknovy ludeknovy commented Mar 1, 2024

In the item creation and CSV processing methods in server controllers, code enhancements were applied to improve memory management. Listeners on csvStream are now explicitly removed upon completion or error to clean up resources. This change also assures that the temporary buffer for processing CSV monitoring data is wiped when the procedure ends.

ludeknovy/jtl-reporter#259

In the item creation and CSV processing methods in server controllers, code enhancements were applied to improve memory management. Listeners on csvStream are now explicitly removed upon completion or error to clean up resources. This change also assures that the temporary buffer for processing CSV monitoring data is wiped when the procedure ends.
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 52.42%. Comparing base (3fb4151) to head (d26f9e6).

Files Patch % Lines
.../server/controllers/item/create-item-controller.ts 0.00% 3 Missing ⚠️
...r/controllers/item/utils/process-monitoring-csv.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   52.58%   52.42%   -0.17%     
==========================================
  Files          98       98              
  Lines        1624     1629       +5     
  Branches      145      145              
==========================================
  Hits          854      854              
- Misses        751      756       +5     
  Partials       19       19              
Flag Coverage Δ
unittests 52.42% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludeknovy ludeknovy merged commit 62d9852 into master Mar 1, 2024
4 of 6 checks passed
@ludeknovy ludeknovy deleted the bugfix/memory-cleanup-csv-processing branch March 1, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant