Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Abort file processing when DB is not responsible #289

Merged
merged 8 commits into from
Feb 10, 2024

Conversation

ludeknovy
Copy link
Owner

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (510e1ea) 53.58% compared to head (4286f3e) 52.65%.

Files Patch % Lines
.../server/controllers/item/create-item-controller.ts 0.00% 103 Missing ⚠️
...rver/controllers/item/shared/item-error-handler.ts 59.09% 5 Missing and 4 partials ⚠️
...ver/controllers/item/stop-item-async-controller.ts 0.00% 3 Missing ⚠️
src/server/errors/data-parsing-exception.ts 25.00% 3 Missing ⚠️
src/server/errors/data-processing-exceptions.ts 25.00% 3 Missing ⚠️
...ver/errors/data-streaming-to-database-exception.ts 25.00% 3 Missing ⚠️
src/server/errors/unlinking-file-exception.ts 25.00% 3 Missing ⚠️
...er/controllers/item/shared/item-data-processing.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   53.58%   52.65%   -0.94%     
==========================================
  Files          93       98       +5     
  Lines        1562     1622      +60     
  Branches      140      145       +5     
==========================================
+ Hits          837      854      +17     
- Misses        710      749      +39     
- Partials       15       19       +4     
Flag Coverage Δ
unittests 52.65% <11.64%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludeknovy ludeknovy merged commit f5d4ec2 into master Feb 10, 2024
4 of 6 checks passed
@ludeknovy ludeknovy deleted the bugfix/handle-unresponsive-db branch February 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant