Fixing hanging specs by specifying the remote debug port. You can use…

… an ENV to override it if you need. Fixes #158
luckyframework · Oct 21, 2023 · e254e71 · e254e71
1 parent 39efab6
commit e254e71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/shard.yml b/shard.yml
@@ -11,10 +11,10 @@ license: MIT
 dependencies:
   selenium:
     github: crystal-loot/selenium.cr
-    version: ~> 0.12.0
+    version: ~> 0.12
   webdrivers:
     github: crystal-loot/webdrivers.cr
-    version: ~> 0.4.2
+    version: ~> 0.4
   habitat:
     github: luckyframework/habitat
     version: ~> 0.4.7

diff --git a/src/lucky_flow/selenium/chrome/driver.cr b/src/lucky_flow/selenium/chrome/driver.cr
@@ -24,6 +24,7 @@ end
 
 LuckyFlow::Registry.register :headless_chrome do
   LuckyFlow::Selenium::Chrome::Driver.new do |config|
-    config.chrome_options.args = ["no-sandbox", "headless", "disable-gpu"]
+    remote_debuggin_port = ENV["CHROME_REMOTE_DEBUGGING_PORT"]? || 9222
+    config.chrome_options.args = ["no-sandbox", "headless", "disable-gpu", "remote-debugging-port=#{remote_debuggin_port}"]
   end
 end