Fix Errno issue with Crystal 0.34.0 and release v0.20.0#499
Merged
Conversation
Member
Author
|
Issue with shards not resolving since we can't override the dependency. I don't want to go create separate branches for every dependency so they point to lucky master. So hoping crystal-lang/shards#299 gets added. If not added by 0.34.0 (which seems quite likely it won't be since 0.34 is pretty close) then I'll wait to get a version of lucky locked down for 0.34.0, then update this to point to that branch and should hopefully be able to test it out |
jkthorne
approved these changes
Apr 5, 2020
Errno was renamed in 0.34.x crystal-lang/crystal#8885 Instead we should just ignore non existent file. That way it works in 0.33 and 0.34
paulcsmith
force-pushed
the
pcs/0.34.0-support
branch
from
b8df0ec to
cb94d3c
Compare
paulcsmith
changed the title
paulcsmith
force-pushed
the
pcs/0.34.0-support
branch
from
b5e361d to
9a19526
Compare
paulcsmith
force-pushed
the
pcs/0.34.0-support
branch
from
9a19526 to
112179e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errno was renamed in 0.34.x crystal-lang/crystal#8885
Instead we should just ignore non existent file. That way it works in
0.33 and 0.34