* Adding Option to Ignore Stop Words (English) from Tag Cloud #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome work @ankit-singhaniya ! Guys if you need any help getting this in let me know! |
|
ping @dougmcclure can someone take a look at this? |
|
ping @dougmcclure can you take a look? |
|
ping can someone take a look at this? @athana |
|
@chrismattmann @ankit-singhaniya Ok, I merged it to |
|
thank you @athana ! |
|
thank you @chrismattmann for bringing this up, and thanks @athana for taking look at the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
@chrismattmann
With this request, I am proposing a Feature Addition into existing Tag Cloud Panel of Banana.
Option to Ignore Stop Words
Description: The Tag Cloud panel is typically to be used with a field with only Keywords, this assumes that the Solr Field does not contain English Stop Words. Even if they did, the count of stop words will surely be prevalent than other keywords to be visualized. Problem with this is when this assumption is invalid on some field of solr index this panel is used on, it results in a Tag Cloud of Stop Words
Solution: Use of a List of Stop Words in English to reject words to be included in the cloud.
Approach: Adding an Option in Panel Settings to be Enabled to Ignore Stop Words from the Solr Field. This way, both the configurations of the panel could be used.
Fig. 1: Original Tag Cloud Panel (and Output on some data)
Fig. 2: Modified Tag Cloud Panel (rejecting Stop Words)
Fig. 3: Original Settings Page for Tag Cloud Panel
Fig. 4: Modified Settings Page for Tag Cloud Panel (adding a check-box for Stop Words)