-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticker Panel Bug: Custom query is always ignored #152
Conversation
Add a fix to include the custom query in the ticker panel when the Solr query is built.
Thank you for reporting this. However, we are unable to reproduce it. Custom query parameters (global parameters) are being added correctly for ticker panel (and other panels) by query service (querySrv.js:118). You can make sure by looking at the "inspect" icon at the top of the panel. |
Global custom query parameters are correctly added. This fix is about panel specific custom queries, which can be added for every panel seperatelly (under "Add Custom Queries"). While all other panels include this custom query in the query by reading out the value in $scope.panel.queries.custom, this is missing for the ticker panel. |
Ticker Panel Bug: Custom query is always ignored
Merged, thanks for the fix! |
Update README.md Upgrade jquery from v1.8.0 to v1.12.1 to fix security vulnerability. Cleanup histogram panel. Add NOTICE.txt Add default form submit action when creating a new dashboard. Add show stats value to Hits panel. Merge branch 'MAVEN_CENTRAL' of https://github.com/lewismc/banana into lewismc-MAVEN_CENTRAL Fix d3.tip module. Merge branch 'add-panel-d3-bar-with-tooltip' of https://github.com/ankit-singhaniya/banana into ankit-singhaniya-add-panel-d3-bar-with-tooltip Merge branch 'ankit-singhaniya-tag-cloud-panel-stop-words' into develop Merge branch 'tag-cloud-panel-stop-words' of https://github.com/ankit-singhaniya/banana into ankit-singhaniya-tag-cloud-panel-stop-words Merge pull request #258 from frankdarcy/develop only create mailto link for username after whitespace or line start Edit .gitignore Remove unused ajax-solr lib. Remove (unused) bower from package.json. Fix bootstrap.dark.min.css and bootstrap.light.min.css. Fix Gruntfile and update grunt-contrib-uglify from 0.5.1 to 0.11.0. Fix Grunt default task. Revise package.json and bower.json. Only create mailto link if username is at start of line or preceeded by whitespace (to avoid matching ftp://user:password@host/path) Add world-antarctica map. Edit map.world.codes.js to capitalized case. Fix filter when using countryName option in map panel. Add banana-int conf directory for Solr 5.x Update README.md to include instructions for Solr 5. Merge pull request #234 from davidfmiller/develop Apple touch icon Merge pull request #222 from davidfmiller/patch-7 Update filesaver.js to latest version Merge branch 'davidfmiller-jshint' into develop Remove redundant fq condition Merge branch 'davidfmiller-export' into develop Fixed terms export rows parameter Merge pull request #226 from davidfmiller/editorconfig Add initial .editorconfig file Merge pull request #227 from davidfmiller/export Centralize downloading/exporting response data Add export to terms panel Only display 'all fields checkbox' for table module Centralize downloading/exporting response data jshint fixes for dashUpload and kibanaPanel jshint fixes Merge pull request #221 from davidfmiller/develop Translation of field names in table micropanel Add field name translation in table panel Add field name translation in full text search panel Allow human-friendly translations for facet fields to be defined on a per-dashboard basis Merge pull request #215 from davidfmiller/develop Update browser window/tab title to reflect current dashboard title Merge pull request #206 from davidfmiller/develop JS Docs for underscore.extended.js + kbn.js in src/app/components Add "sorted" clarification to get_object_fields method description add build.number to .gitignore JS docs for underscore.extended + kbn Merge pull request #205 from davidfmiller/develop Method documentation & typo clean-up in kbn.js Merge pull request #204 from jbrucher/patch-1 Fix map panel height under IE 9-11 In IE 9-11 the panel height or row height is not recognized probably and therefor the default height of 20px is always set. Changing line 62 to use ng-syle IE is recognizing style propably! Tested for both IE and FF. Merge pull request #199 from aadel/solr5-cors Solr 5 CORS update Merge pull request #179 from nickvasilyev/develop Issue #52 Fix. Thanks Nick! Merge pull request #197 from wlbhiro/develop Fix : Bug exclude_filter of value change to Empty value. Add a new panel called docviewer for displaying a search result like a document viewer with a title field and a content field with highlighting. Adding D3 Bar Chart Panel Adding Option to Ignore Stop Words (English) from Tag Cloud Adding (as an option in panel settings) to use Country Names to Detect Countries from the Result rather than using Country Codes Adding Antarctica Region to World Map in Map Panel Merge pull request #169 from wrdrvr/develop Sunburst panel Removed unused code and fixed the loading indicator Removed a no longer needed function and fixed loading indicator. Fixed persistent tooltip, set rows to 0 in query Fixed tooltips that were hanging around after reload and added rows=0 to Added a sunburst panel Merge pull request #163 from iperminov/develop Filtering panel: wrap and truncate long values to display Merge pull request #159 from iperminov/develop Use POST instead of GET in Solr client to do search Merge pull request #152 from dhasenfratz/develop Ticker Panel Bug: Custom query is always ignored Add figures for tutorial on how to build a custom panel. Reformat the code for template panel. Add template panel for tutorial on how to build a custom panel. Add thousandSeparator filter to format numbers. Add a new solrSrv service. This will be used to enhance and optimize Solr requests. Improve micro panel in the Table panel by adding an option to calculate the top field values from all data in Solr. Table panel will now dynamically display non-empty fields on the field list. Fix: Turn off sorting in Table panel by default. Add option to limit the max number of facet fields to Facet panel, and cleanup code. Merge pull request #146 from titellus/improvements/panels/terms/add-sort-by-count-or-index Dashboard / Term panel / Add sort by index or count. Fix syntax errors when using strict equality in ng-show and ng-hide directives. Change to == instead. Merge pull request #140 from titellus/improvements/panels/filter/set-filter-from-location-search-q-parameter Filter panel / Initialize filters from q parameter in location. Filter panel / Trigger refresh on load. Merge pull request #112 from karimfikry/develop Fix change Heatmap cells color update Merge pull request #114 from tarek-salah/fix_toggle_button Fix toggle in filter panel Fixed change color of heatmap cells Merge pull request #109 from tarek-salah/develop Validate empty fields when adding to *Table* panel Merge pull request #100 from karimfikry/develop Fixing Table paging issue after refresh Merge pull request #107 from aadel/configurable_timefield Configurable timefield in new dashboard pop-up. Fix table panel: adding empty fields accepted Consistent time field across settings files Configurable time field Fixed table index when results are 0 entries Changed kibana-dashboard to banana-dashboard in saved gist Fixed table indexing and re-strating offset after changing dashboard
Add a fix to include the custom query in the ticker panel
when the Solr query is built.