-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): Add house-wifi icon #2723
Conversation
Added or changed iconsIcons as codeWorks for: const HouseWifiIcon = createLucideIcon('HouseWifi', [
["path",{"d":"M9.5 13.866a4 4 0 0 1 5 .01"}],
["path",{"d":"M12 17h.01"}],
["path",{"d":"M3 10a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z"}],
["path",{"d":"M7 10.754a8 8 0 0 1 10 0"}]
]) |
This has guideline violations. Some alternative design ideas: |
the first one seems okay. |
icons/home-wifi.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our icon naming conventions this should be house-wifi
.
does this look okay now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@jguddas @ericfennis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributors should be inherited from the icons you based this on.
Done. |
@ericfennis could you please review this PR and merge if possible! |
Nice work @akshaymemane ! |
I appreciate you all for the quick review and approvals! |
What is the purpose of this pull request?
Description
Adds new home-wifi icon
Icon use case
My use case is for a "Smart Home" feature, where I show this icon to represent smart home.
Another use case could be a "Home with Wifi".
Alternative icon designs
I don't have alternate designs.
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting