Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add house-wifi icon #2723

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

akshaymemane
Copy link
Contributor

@akshaymemane akshaymemane commented Jan 8, 2025

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds new home-wifi icon

Icon use case

My use case is for a "Smart Home" feature, where I show this icon to represent smart home.

Another use case could be a "Home with Wifi".

Alternative icon designs

I don't have alternate designs.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: house
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Added or changed icons

icons/house-wifi.svg

Preview cohesion icons/square-kanban.svg
icons/house-wifi.svg
icons/clock-7.svg
Preview stroke widths icons/house-wifi.svg
icons/house-wifi.svg
icons/house-wifi.svg
DPI Preview (24px) icons/house-wifi.svg
Icon X-rays icons/house-wifi.svg
Icon Diffs icons/house-wifi.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HouseWifiIcon = createLucideIcon('HouseWifi', [
  ["path",{"d":"M9.5 13.866a4 4 0 0 1 5 .01"}],
  ["path",{"d":"M12 17h.01"}],
  ["path",{"d":"M3 10a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z"}],
  ["path",{"d":"M7 10.754a8 8 0 0 1 10 0"}]
])

@karsa-mistmere
Copy link
Member

This has guideline violations. Some alternative design ideas:

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

@akshaymemane
Copy link
Contributor Author

This has guideline violations. Some alternative design ideas:

iconsOpen lucide studio

iconsOpen lucide studio

iconsOpen lucide studio

the first one seems okay.
Will update the PR.
Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our icon naming conventions this should be house-wifi.

@jguddas
Copy link
Member

jguddas commented Jan 9, 2025

image
What about making those match?

@akshaymemane
Copy link
Contributor Author

image What about making those match?

icons
Open lucide studio

does this look okay now?

@akshaymemane akshaymemane changed the title feat(icons): Add home-wifi icon feat(icons): Add house-wifi icon Jan 9, 2025
Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@akshaymemane
Copy link
Contributor Author

@jguddas @ericfennis
Could you please review this once!

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributors should be inherited from the icons you based this on.

@akshaymemane
Copy link
Contributor Author

Contributors should be inherited from the icons you based this on.

Done.

@akshaymemane
Copy link
Contributor Author

@ericfennis could you please review this PR and merge if possible!

@ericfennis
Copy link
Member

Nice work @akshaymemane !

@ericfennis ericfennis merged commit d5fe5a0 into lucide-icons:main Jan 10, 2025
8 checks passed
@akshaymemane
Copy link
Contributor Author

Nice work @akshaymemane !

I appreciate you all for the quick review and approvals!

@akshaymemane akshaymemane deleted the home-wifi branch January 10, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants