Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): upgrade snowflake icons to match real life #2610

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Bug fix

Description

Real snowflakes have six-fold rotational symmetry, this PR upgrades snowflake icons to look more accurate and have better uniformity between them.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Added or changed icons

icons/snowflake.svgicons/sun-snow.svgicons/thermometer-snowflake.svg

Preview cohesion icons/square-dot.svgicons/square-bottom-dashed-scissors.svgicons/square-check.svg
icons/snowflake.svgicons/sun-snow.svgicons/thermometer-snowflake.svg
icons/circle-slash.svgicons/cloudy.svgicons/calendar-minus-2.svg
Preview stroke widths icons/snowflake.svgicons/sun-snow.svgicons/thermometer-snowflake.svg
icons/snowflake.svgicons/sun-snow.svgicons/thermometer-snowflake.svg
icons/snowflake.svgicons/sun-snow.svgicons/thermometer-snowflake.svg
DPI Preview (24px) icons/snowflake.svg icons/sun-snow.svg icons/thermometer-snowflake.svg
Icon X-rays icons/snowflake.svg icons/sun-snow.svg icons/thermometer-snowflake.svg
Icon Diffs icons/snowflake.svg icons/sun-snow.svg icons/thermometer-snowflake.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SnowflakeIcon = createLucideIcon('Snowflake', [
  ["path",{"d":"m10 20-1.25-2.5L6 18"}],
  ["path",{"d":"M10 4 8.75 6.5 6 6"}],
  ["path",{"d":"m14 20 1.25-2.5L18 18"}],
  ["path",{"d":"m14 4 1.25 2.5L18 6"}],
  ["path",{"d":"m17 21-3-6h-4"}],
  ["path",{"d":"m17 3-3 6 1.5 3"}],
  ["path",{"d":"M2 12h6.5L10 9"}],
  ["path",{"d":"m20 10-1.5 2 1.5 2"}],
  ["path",{"d":"M22 12h-6.5L14 15"}],
  ["path",{"d":"m4 10 1.5 2L4 14"}],
  ["path",{"d":"m7 21 3-6-1.5-3"}],
  ["path",{"d":"m7 3 3 6h4"}]
])

const SunSnowIcon = createLucideIcon('SunSnow', [
  ["path",{"d":"M10 21v-1"}],
  ["path",{"d":"M10 4V3"}],
  ["path",{"d":"M10 9a3 3 0 0 0 0 6"}],
  ["path",{"d":"m14 20 1.25-2.5L18 18"}],
  ["path",{"d":"m14 4 1.25 2.5L18 6"}],
  ["path",{"d":"m17 21-3-6 1.5-3H22"}],
  ["path",{"d":"m17 3-3 6 1.5 3"}],
  ["path",{"d":"M2 12h1"}],
  ["path",{"d":"m20 10-1.5 2 1.5 2"}],
  ["path",{"d":"m3.64 18.36.7-.7"}],
  ["path",{"d":"m4.34 6.34-.7-.7"}]
])

const ThermometerSnowflakeIcon = createLucideIcon('ThermometerSnowflake', [
  ["path",{"d":"m10 20-1.25-2.5L6 18"}],
  ["path",{"d":"M10 4 8.75 6.5 6 6"}],
  ["path",{"d":"M10.585 15H10"}],
  ["path",{"d":"M2 12h6.5L10 9"}],
  ["path",{"d":"M20 14.54a4 4 0 1 1-4 0V4a2 2 0 0 1 4 0z"}],
  ["path",{"d":"m4 10 1.5 2L4 14"}],
  ["path",{"d":"m7 21 3-6-1.5-3"}],
  ["path",{"d":"m7 3 3 6h2"}]
])

@jguddas
Copy link
Member

jguddas commented Nov 13, 2024

What about arcifying the inner hexagon?

@karsa-mistmere
Copy link
Member Author

What about arcifying the inner hexagon?

Does that even make sense here?

At 1x, there isn't any perceptible difference, I think:
image

When scaled up, I think no arcs is definitely the way to go:
image

@ericfennis ericfennis merged commit ea0ac2f into main Dec 20, 2024
7 of 8 checks passed
@ericfennis ericfennis deleted the icon/snowflake branch December 20, 2024 09:36
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants