Bump to egui 0.24 #13
Conversation
|
Hi! Thanks for opening the PR! I guess this is blocked on the update of egui-sdl2-event? Maybe you can also open an issue over there? |
| @@ -92,7 +92,7 @@ impl Painter { | |||
| Some(pos) => { | |||
| let old_image = self.paints.remove(id).unwrap().image; | |||
|
|
|||
| let mut surface = Surface::new_raster_n32_premul(skia_safe::ISize::new( | |||
| let mut surface = surfaces::raster_n32_premul(skia_safe::ISize::new( | |||
There was a problem hiding this comment.
Since it seems like the surface api changed, you should probably also bump the minimum version of skia I think?
| // TODO: How to handle multiple outputs | ||
| viewport_output: _ |
There was a problem hiding this comment.
I have no idea how this should be handled here btw. I guess for actual rendering to a window, we'd need to ask winit or sdl?
For my use case I'm only using this crate to render to a texture, and then this makes little sense
There was a problem hiding this comment.
Hmm, I think for now we can ignore multiple viewports, as long as a single one works correctly as it did before. If someone requires that feature they can open a pull request. Maybe we could add a note to the readme that this is currently not supported.
|
Seems like egui-sdl2-events is updated to egui 0.24: https://github.com/kaphula/egui-sdl2-event/blob/master/lib/Cargo.toml (but not 0.25) |
|
I just realized that egui_skia only depends on egui-sdl2-events for the two sdl examples, maybe we could just comment the dependency until it is updated to the most recent version (egui already seems to be updated to 0.26 now), and add a note to the two examples that they currently won't work. But still, at least the winit integration will need to be updated before we can release an update with a current egui version. I don't use this crate anymore so I can't put the work into updating but I'm happy to review and help so we can get a new version released soon. |
I'm actively using it, but only for the rendering to images for snapshot testing of https://gitlab.com/surfer-project/surfer. I therefore keep my fork up-to-date enough to work for that, but don't really have the time to update the rest of the library. If you are open to scaling the library back to only the software rendering part, I'd be happy to maintain it. |
This bumps egui to 0.24 which had incompatibilities with the previous version.
egui-sdl2-event is still on on 0.23 or older so the tests or examples don't currently run