fix(ci): pr-title skip uses pull_request.user.login (take 2)#44
Merged
fix(ci): pr-title skip uses pull_request.user.login (take 2)#44
Conversation
PR #43 intentó skipear pr-title.yml para Dependabot usando `github.actor != 'dependabot[bot]'`. No funcionó: en re-runs (via @dependabot rebase comment), github.actor parece quedar con el initiator del comment, no con el bot. Los runs de #39, #40, #41 siguieron fallando incluso después del rebase. Fix: chequear `github.event.pull_request.user.login` que es el creador del PR, invariante a re-runs/rebases. Para Dependabot PRs ese campo siempre es 'dependabot[bot]'. Verificable en logs de PR #40 run 25201147028: el job ejecutó (no se skipeó), confirmando que la condición github.actor evaluó a true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Take 2 sobre el fix de pr-title.yml para Dependabot. PR #43 intentó skipear el job con
github.actor != 'dependabot[bot]'. No funcionó en la práctica: los re-runs de #39/#40/#41 (después del @dependabot rebase) siguieron fallando, indicando quegithub.actorno resolvió al bot.Causa probable: en re-runs/rebase-via-comment,
github.actorqueda con el initiator del comment, no con el bot que pushea.Fix
Cambiar la condición a
github.event.pull_request.user.login != 'dependabot[bot]'. El user.login del PR es el creador, invariante a re-runs.Tests
Probado
Validate PR titleskipped en lugar de failed.