Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typing): set callback as a optional argument #60

Merged
merged 1 commit into from
Feb 16, 2022
Merged

fix(typing): set callback as a optional argument #60

merged 1 commit into from
Feb 16, 2022

Conversation

renbaoshuo
Copy link
Contributor

The documentation mentions that the callback function is an optional option, but in the code this option is incorrectly set. This Pull Request aims to resolve this issue.

@lucafalasco
Copy link
Owner

thanks @renbaoshuo!

@lucafalasco lucafalasco merged commit f1fbec2 into lucafalasco:master Feb 16, 2022
@lucafalasco lucafalasco mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucafalasco lucafalasco lucafalasco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renbaoshuo @lucafalasco