Skip to content

chore: bump dependencies#44

Closed
lino-levan wants to merge 2 commits intolucacasonato:mainfrom
lino-levan:main
Closed

chore: bump dependencies#44
lino-levan wants to merge 2 commits intolucacasonato:mainfrom
lino-levan:main

Conversation

@lino-levan
Copy link
Copy Markdown

No description provided.

@jsejcksn
Copy link
Copy Markdown
Contributor

@lino-levan

  1. This is outdated after feat: inline import maps + stacked plugin support #47 was merged.

  2. Did you see that there's an update task? You can use it as a basis for updating this PR after rebasing it on the main branch:

    "update": "deno run --allow-read=./ --allow-net --allow-write=./ https://deno.land/x/deno_outdated@0.2.4/cli.ts"

Comment thread deps.ts
Comment on lines 4 to +8
fromFileUrl,
resolve,
toFileUrl,
} from "https://deno.land/std@0.173.0/path/mod.ts";
export { basename, extname } from "https://deno.land/std@0.173.0/path/mod.ts";
} from "https://deno.land/std@0.178.0/path/mod.ts";
export { basename, extname } from "https://deno.land/std@0.178.0/path/mod.ts";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two path exports use the same specifier and can be merged into one statement.

Comment thread deps.ts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant today, but... TypeScript 5.0 will ship tomorrow, and will include support for export type * (commit).

Whenever Deno updates its TS version to support this new syntax, the following can be rewritten:

Before:

import type * as esbuild from "https://deno.land/x/esbuild@v0.17.11/mod.d.ts";
export type { esbuild };

After:

export type * as esbuild from "https://deno.land/x/esbuild@v0.17.11/mod.d.ts";

@lino-levan lino-levan closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants