Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: output subprocess logs only when the dumpio option is enabled #14

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fix: output subprocess logs only when the dumpio option is enabled #14

merged 1 commit into from
Apr 2, 2021

Conversation

masnagam
Copy link
Contributor

This PR fixes #8.

@klaushvam
Copy link

klaushvam commented Feb 6, 2021 •
edited
Loading

Would be lovely to get this change in main, my logs are starting to become quite big

lucacasonato
lucacasonato approved these changes Apr 2, 2021
View reviewed changes
Copy link
Owner

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lucacasonato lucacasonato merged commit aa7dc66 into lucacasonato:main Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't unconditionally output chrome subprocess logs on exit
3 participants
@masnagam @klaushvam @lucacasonato