Fix netcoreapp projects for Linux #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 91 91
Lines 27663 27663
Branches 1938 1938
=======================================
Hits 25490 25490
Misses 1926 1926
Partials 247 247
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 91 91
Lines 27663 27663
Branches 1938 1938
=======================================
Hits 25490 25490
Misses 1926 1926
Partials 247 247
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get the netcoreapp2.0 projects building again, and running on Linux. I've only tested this building with Visual Studio 2017 and running on Windows 10 (WGL) & Ubuntu 18.04 (GLX).
On Ubuntu, I had to create the symlink
/usr/lib/x86_64-linux-gnu/libX11.so -> /usr/lib/x86_64-linux-gnu/libX11.so.6in addition to these changes. This isn't required under Mono because Mono supports DLLMap. While .NET Core doesn't support DLLMap, Core 3.0 is adding similar functionality.Project file changes were copied from pull request #101 to fix issues with the use of
BaseIntermediateOutputPathin order to get the project files to load properly.I added #defines around the
dlopenDllImports to account for marshaling differences, as noted in issue #107.Finally, I removed the #define around the version info in AssemblyInfo.cs. This was causing assembly load errors because the assembly had an incorrect version (0.0.0.0).