Lunatik states management for GSoC 2020 #20
Conversation
MatheusNtg
force-pushed
the
tests
branch
2 times, most recently
from
2f27696
to
ca791dc
Compare
MatheusNtg
force-pushed
the
tests
branch
3 times, most recently
from
87be836
to
aad75a1
Compare
| @@ -0,0 +1,3 @@ | |||
| [submodule "deps/lua-memory"] | |||
| path = deps/lua-memory | |||
| url = https://github.com/MatheusNtg/lua-memory | |||
There was a problem hiding this comment.
it should refers to upstream, right? or do you have modifications in your fork?
There was a problem hiding this comment.
I have modifications on my fork.
There was a problem hiding this comment.
so, you need to make a PR as well.. what's the upstream repo? I think we should fork it on luainkernel and make a PR for it..
There was a problem hiding this comment.
The upstream repo can be found here. I made a PR to lua-memory repo now
Makefile
Outdated
| @@ -1,4 +1,5 @@ | |||
| ccflags-y += -D_LUNATIK -D_KERNEL -I$(src) -D_CONFIG_FULL_PANIC | |||
| ccflags-y += -D_LUNATIK -D_KERNEL -I$(src) -D_CONFIG_FULL_PANIC -DLUNATIK_UNUSED \ | |||
| -I$(src)/lua -I$(src)/deps/lua-memory/src | |||
There was a problem hiding this comment.
| -I$(src)/lua -I$(src)/deps/lua-memory/src | |
| -I$(src)/lua -I$(src)/deps/lua-memory/src |
There was a problem hiding this comment.
please review and apply the same to the rest of the code..
Makefile
Outdated
| lua/lundump.o lua/lvm.o lua/lzio.o lua/lauxlib.o lua/lbaselib.o \ | ||
| lua/lbitlib.o lua/lcorolib.o lua/ldblib.o lua/lstrlib.o \ | ||
| lua/ltablib.o lua/lutf8lib.o lua/loslib.o lua/lmathlib.o lua/linit.o \ | ||
| lua/loadlib.o luautil.o |
There was a problem hiding this comment.
why changing all these lines?
There was a problem hiding this comment.
To put all lua related objects in on variable on the Lunatik building
There was a problem hiding this comment.
you don't need change the indentation of this lines to do that.. please, take cara of that..
Makefile
Outdated
| lua/ltablib.o lua/lutf8lib.o lua/loslib.o lua/lmathlib.o lua/linit.o \ | ||
| lua/loadlib.o luautil.o | ||
|
|
||
| lua_memory-objs = deps/lua-memory/src/lmemlib.o deps/lua-memory/src/lmemmod.o |
There was a problem hiding this comment.
| lua_memory-objs = deps/lua-memory/src/lmemlib.o deps/lua-memory/src/lmemmod.o | |
| luamemory-path = deps/lua-memory/src | |
| luamemory-objs = $(luamemory-path)/lmemlib.o $(luamemory-path)/lmemmod.o |
| @@ -0,0 +1,53 @@ | |||
| # Copyright (c) 2020 Matheus Rodrigues <[email protected]> | |||
There was a problem hiding this comment.
why are you copying this makefile if you have a submodule?
There was a problem hiding this comment.
This is the makefile of lunatik user space module. What are you suggesting is to build the lunatik user space module from the submodule makefile?
lunatik_conf.h
Outdated
| #ifndef LUNATIK_CONF_H | ||
| #define LUNATIK_CONF_H | ||
|
|
||
| #define LUNATIK_NAME_MAXSIZE 64 /* Max length of Lua state name */ |
There was a problem hiding this comment.
please, use the form:
#define <name>\t(<definition>)
and apply this to all your definitions..
MatheusNtg
force-pushed
the
tests
branch
4 times, most recently
from
a071917
to
8a8297a
Compare
lib/tests/list.lua
Outdated
| assert(#states == 6) | ||
| assert(#states2 == 6) | ||
|
|
||
|
|
| -- State created from another session | ||
| ss2 = session2:newstate's1' | ||
| assert(ss2 == nil) | ||
|
|
MatheusNtg
force-pushed
the
tests
branch
5 times, most recently
from
eeb6a66
to
cb9b7c6
Compare
…ion and rename state creation API
…umentation and rename state creation API
No description provided.