Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] download_url function needs three params but only two passed when called in copy_install function #848

Closed
Maslino opened this issue Jul 9, 2024 · 10 comments

Comments

@Maslino
Copy link

Maslino commented Jul 9, 2024

As the following code shows

def copy_install(files, js_path_name=None):
    for url in files:
        if url.endswith("/"):
            url = url[:-1]
        try:
            if url.endswith(".py"):
                download_url(url, core.custom_nodes_path)                           # this call
            else:
                path = os.path.join(core.js_path, js_path_name) if js_path_name is not None else core.js_path
                if not os.path.exists(path):
                    os.makedirs(path)
                download_url(url, path)                                             # and this call

        except Exception as e:
            print(f"Install(copy) error: {url} / {e}", file=sys.stderr)
            return False

    print("Installation was successful.")
    return True
@MAkC8
Copy link

MAkC8 commented Jul 9, 2024

ComfyUI does not load Manager as usual. May this bug disappear Manager button ?
Screenshot 2024-07-09 at 5 40 54 PM

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 9, 2024

I have no problem. What is your terminal log?

@MAkC8
Copy link

MAkC8 commented Jul 9, 2024

I using Vast.ai with docker image of "ghcr.io/ai-dock/comfyui:latest-jupyter" which install ComfyUI-Manager by default. Always it is ok , but today it's button didn't visible ...
I couldn't find the log of loading ComfyUI-Manager from server. I just have these logs from panel :

### Loading: ComfyUI-Manager (V2.46.1)
### ComfyUI Revision: 2129 [719fb2c8] *DETACHED | Released on '2024-04-14'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
==> /var/log/supervisor/serviceportal.log <==
INFO:     185.124.108.178:0 - "POST /ajax/processes/restart HTTP/1.1" 200 OK
INFO:     185.124.108.178:0 - "POST /ajax/logs HTTP/1.1" 200 OK
==> /var/log/supervisor/supervisor.log <==
2024-07-09 13:54:41,407 INFO success: comfyui entered RUNNING state, process has stayed up for > than 5 seconds (startsecs)
==> /var/log/supervisor/serviceportal.log <==
INFO:     ('185.124.108.178', 0) - "WebSocket /ai-dock/logtail.sh" [accepted]

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 9, 2024

Why are you using old version of ComfyUI? ComfyUI Revision: 2129 [719fb2c8] *DETACHED
Btw, press F12 and see browser console log if your are using chrome browser.

@MAkC8
Copy link

MAkC8 commented Jul 9, 2024

Is there any shortcut for command to show manager window without touching button of "Manager" from right panel ?

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 9, 2024

I confirmed that issue is the problem of the old ComfyUI version (the specific commit hash 719fb2c8).
You have to update ComfyUI.

@ltdrdata ltdrdata closed this as completed Jul 9, 2024
@MAkC8
Copy link

MAkC8 commented Jul 9, 2024

I just run the last version right now, I thought maybe it related to new version.
this is the console log of browser for the latest version:
Screenshot 2024-07-09 at 6 12 06 PM

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 9, 2024

I just run the last version right now, I thought maybe it related to new version. this is the console log of browser for the latest version: Screenshot 2024-07-09 at 6 12 06 PM

That issue is fixed now.

@MAkC8
Copy link

MAkC8 commented Jul 9, 2024

Maybe it related to ComfyUI version?

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 9, 2024

Maybe it related to ComfyUI version?
image

While ComfyUI-Manager now supports a new style menu, a backward compatibility feature was included for users of older versions of ComfyUI. However, this feature had an error, causing issues for those using older ComfyUI versions.

The problem can be resolved by either updating ComfyUI-Manager to the latest version or by updating ComfyUI itself to the most recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants