Frontend vueNode (node 2.0) support for mask rect area nodes#1167
Merged
ltdrdata merged 1 commit intoltdrdata:Mainfrom Jan 2, 2026
Merged
Frontend vueNode (node 2.0) support for mask rect area nodes#1167ltdrdata merged 1 commit intoltdrdata:Mainfrom
ltdrdata merged 1 commit intoltdrdata:Mainfrom
Conversation
Contributor
|
Hi! Just a heads up: I recently opened PR #1168 which fixes INT input handling, live preview synchronization, and layout calculations for Mask Rect Area nodes. This PR touches frontend integration and assumes specific node dimensions and behavior. Since PR #1168 adjusts the core INT input handling and layout calculations of the affected nodes, it’s safer to review or rebase this change after #1168 is merged, to ensure it aligns with the final node behavior and avoids redundant fixes. |
Contributor
Author
Thanks for update! I would like to make mine as draft, and check once yours merged, there is anything we need to make on ComfyUI frontend side |
jtydhr88
force-pushed
the
vueNodes-support
branch
from
e2bc530 to
58c3853
Compare
jtydhr88
added a commit
to Comfy-Org/ComfyUI_frontend
that referenced
this pull request
Jan 2, 2026
## Summary - Fix widget callback signature to pass node as 3rd parameter for extensions like Impact Pack - Add triggerDraw call to update all legacy widgets when any widget value changes - Support computeLayoutSize for dynamic widget height calculation - Set node.canvasHeight for extensions that rely on this property - Use step/10 for number input buttons to match litegraph behavior Fixes display and interaction issues with Impact Pack's Mask Rect Area nodes. fix #7615 and #7616 it also requires Impact pack PR ltdrdata/ComfyUI-Impact-Pack#1167 ## Screenshots Before https://github.com/user-attachments/assets/eb890f7c-c1a0-4c7b-a8d7-dde304de83e4 After https://github.com/user-attachments/assets/dad65b52-d71e-4c19-92c0-367b7dcafed0 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7766-fix-Improve-legacy-widget-compatibility-in-vueNodes-mode-2d56d73d365081b18d83f4a41ff0f377) by [Unito](https://www.unito.io)
ltdrdata
approved these changes
Jan 2, 2026
github-actions bot
pushed a commit
to Comfy-Org/ComfyUI_frontend
that referenced
this pull request
Jan 13, 2026
## Summary - Fix widget callback signature to pass node as 3rd parameter for extensions like Impact Pack - Add triggerDraw call to update all legacy widgets when any widget value changes - Support computeLayoutSize for dynamic widget height calculation - Set node.canvasHeight for extensions that rely on this property - Use step/10 for number input buttons to match litegraph behavior Fixes display and interaction issues with Impact Pack's Mask Rect Area nodes. fix #7615 and #7616 it also requires Impact pack PR ltdrdata/ComfyUI-Impact-Pack#1167 ## Screenshots Before https://github.com/user-attachments/assets/eb890f7c-c1a0-4c7b-a8d7-dde304de83e4 After https://github.com/user-attachments/assets/dad65b52-d71e-4c19-92c0-367b7dcafed0 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7766-fix-Improve-legacy-widget-compatibility-in-vueNodes-mode-2d56d73d365081b18d83f4a41ff0f377) by [Unito](https://www.unito.io)
github-actions bot
pushed a commit
to Comfy-Org/ComfyUI_frontend
that referenced
this pull request
Jan 13, 2026
## Summary - Fix widget callback signature to pass node as 3rd parameter for extensions like Impact Pack - Add triggerDraw call to update all legacy widgets when any widget value changes - Support computeLayoutSize for dynamic widget height calculation - Set node.canvasHeight for extensions that rely on this property - Use step/10 for number input buttons to match litegraph behavior Fixes display and interaction issues with Impact Pack's Mask Rect Area nodes. fix #7615 and #7616 it also requires Impact pack PR ltdrdata/ComfyUI-Impact-Pack#1167 ## Screenshots Before https://github.com/user-attachments/assets/eb890f7c-c1a0-4c7b-a8d7-dde304de83e4 After https://github.com/user-attachments/assets/dad65b52-d71e-4c19-92c0-367b7dcafed0 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7766-fix-Improve-legacy-widget-compatibility-in-vueNodes-mode-2d56d73d365081b18d83f4a41ff0f377) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend vueNodes (node 2.0) support.
please merge this after FE changes Comfy-Org/ComfyUI_frontend#7766