Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWEB Light Client #8

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
97378d8
Allow p2pkh outputs to be spent
hectorchu Jan 8, 2024
83b49cc
Allow shutdown during recovery
hectorchu Jan 8, 2024
8b1b72a
Fix mobile build
hectorchu Jan 8, 2024
0cfc33f
Fix compat with latest ltcd
hectorchu Jan 8, 2024
6d54898
Add mweb type to NewAddress
hectorchu Jan 19, 2024
d54a5a2
Add mweb to lncli NewAddress
hectorchu Jan 21, 2024
f6c6fab
Include mweb utxos in ListUnspent
hectorchu Jan 23, 2024
9897f32
Show correct rawtx
hectorchu Feb 2, 2024
8638181
Add basic mweb integration test
hectorchu Feb 5, 2024
12afd01
Simplify
hectorchu Feb 5, 2024
3bc8546
Remove the need to build and install lnd beforehand
hectorchu Feb 5, 2024
9778db9
Test mweb send within wallet
hectorchu Feb 6, 2024
0d173b8
Check txhash
hectorchu Feb 6, 2024
b9cb835
Add pegout test
hectorchu Feb 6, 2024
4653ec9
Test pegout maturity
hectorchu Feb 6, 2024
5f1e9c3
Add pegin to self test
hectorchu Feb 6, 2024
6d49525
Simplify generate
hectorchu Feb 6, 2024
d5f4ff1
Test send mweb to litecoind
hectorchu Feb 6, 2024
75739e9
Test pegout to litecoind
hectorchu Feb 6, 2024
752d47f
Complex pegin-pegout transaction
hectorchu Feb 7, 2024
7fc99c3
Many inputs/outputs test
hectorchu Feb 7, 2024
161fb0f
Add stress test
hectorchu Feb 15, 2024
a15798a
Tidy up
hectorchu Feb 15, 2024
13ca4da
Stress test lnd -> lnd
hectorchu Feb 15, 2024
8d54b26
Upgraded transaction detail
hectorchu Feb 16, 2024
e0f6b25
Use ConnectPeer method
hectorchu Feb 17, 2024
652eda0
Update test values
hectorchu Feb 18, 2024
0560529
Revert previous commit
hectorchu Feb 19, 2024
01d0b34
v21 doesn't have -rpcwaittimeout
hectorchu Feb 19, 2024
f6742d9
Fix mweb test
hectorchu Feb 23, 2024
eff15e3
Fix build
hectorchu Feb 23, 2024
dc17b5b
Fix protos
hectorchu Feb 23, 2024
e3ca0ed
Switching to go workspaces
hectorchu Feb 28, 2024
7fda18c
Add mweb witness types
hectorchu Mar 1, 2024
9a786eb
Skip mweb segwit outputs in test
hectorchu Mar 1, 2024
49c6ae3
Update fees in test
hectorchu Mar 4, 2024
319fdd1
Generate android protos
hectorchu Mar 8, 2024
e7902a1
Fix crash on systems which don't have localhost
hectorchu Apr 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lnwallet/btcwallet/btcwallet.go
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,10 @@ func minedTransactionsToDetails(
}
txDetail.Value = balanceDelta

if tx.Broadcast != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorchu in which case is the incorrect rawtx given?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MWEB txns. Because after we've broadcast it we modify the MsgTx to add 'in the clear' MWEB inputs and outputs to the MsgTx, from the MsgTx.Mweb data. So the serialized tx changes. We save the original broadcast serialization in a separate field.

txDetail.RawTx = tx.Broadcast
}

details = append(details, txDetail)
}

Expand Down Expand Up @@ -1428,6 +1432,10 @@ func unminedTransactionsToDetail(
}
txDetail.Value = balanceDelta

if summary.Broadcast != nil {
txDetail.RawTx = summary.Broadcast
}

return txDetail, nil
}

Expand Down