Skip to content

Fixed create user method and updated test recordings #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsundaralingam merged 1 commit into from
Jan 28, 2021
Merged

Fixed create user method and updated test recordings #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ure-communication-identity/azure/communication/identity/_communication_identity_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def create_user(self, **kwargs):
:rtype: ~azure.communication.identity.CommunicationUserIdentifier
"""
return self._identity_service_client.communication_identity.create(
cls=lambda pr, u, e: CommunicationUserIdentifier(u.id),
cls=lambda pr, u, e: CommunicationUserIdentifier(u.identity.id),
**kwargs)

@distributed_trace
Expand All @@ -105,7 +105,7 @@ def create_user_with_token(
~azure.communication.identity.CommunicationUserToken)
"""
return self._identity_service_client.communication_identity.create(
cls=lambda pr, u, e: CommunicationUserIdentifier(u.id),
cls=lambda pr, u, e: CommunicationUserIdentifier(u.identity.id),
create_token_with_scopes=scopes,
**kwargs)

Expand Down
4 changes: 2 additions & 2 deletions ...ication-identity/azure/communication/identity/aio/_communication_identity_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ async def create_user(self, **kwargs):
:rtype: ~azure.communication.identity.CommunicationUserIdentifier
"""
return await self._identity_service_client.communication_identity.create(
cls=lambda pr, u, e: CommunicationUserIdentifier(u.id),
cls=lambda pr, u, e: CommunicationUserIdentifier(u.identity.id),
**kwargs)

@distributed_trace_async
Expand All @@ -109,7 +109,7 @@ async def create_user_with_token(
"""
return await self._identity_service_client.communication_identity.create(
create_token_with_scopes=scopes,
cls=lambda pr, u, e: CommunicationUserIdentifier(u.id),
cls=lambda pr, u, e: CommunicationUserIdentifier(u.identity.id),
**kwargs)

@distributed_trace_async
Expand Down
26 changes: 14 additions & 12 deletions ...cation-identity/tests/recordings/test_communication_identity_client.test_create_user.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interactions:
- request:
body: null
body: '{}'
headers:
Accept:
- application/json
Expand All @@ -9,34 +9,36 @@ interactions:
Connection:
- keep-alive
Content-Length:
- '0'
- '2'
Content-Type:
- application/json
Date:
- Tue, 22 Dec 2020 18:26:56 GMT
- Wed, 27 Jan 2021 23:54:39 GMT
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
x-ms-return-client-request-id:
- 'true'
method: POST
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2021-03-07
response:
body:
string: '{"id": "sanitized"}'
string: '{"identity": {"id": "8:acs:713bd27c-3c73-4c55-a3d2-11c120d32fa8_00000007-e626-e90a-6216-1f3a0d003bb4"}}'
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
content-type:
- application/json; charset=utf-8
date:
- Tue, 22 Dec 2020 18:26:55 GMT
- Wed, 27 Jan 2021 23:54:40 GMT
ms-cv:
- 4whAoum970WIzePHLz1Ujg.0
- V3Rpav/bY0WZnu7vMclLog.0
strict-transport-security:
- max-age=2592000
transfer-encoding:
- chunked
x-processing-time:
- 18ms
- 229ms
status:
code: 200
message: OK
code: 201
message: Created
version: 1
24 changes: 13 additions & 11 deletions ...recordings/test_communication_identity_client.test_create_user_from_managed_identity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interactions:
- request:
body: null
body: '{}'
headers:
Accept:
- application/json
Expand All @@ -9,30 +9,32 @@ interactions:
Connection:
- keep-alive
Content-Length:
- '0'
- '2'
Content-Type:
- application/json
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
method: POST
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2021-03-07
response:
body:
string: '{"id": "sanitized"}'
string: '{"identity": {"id": "8:acs:3de2c19f-8f12-45ac-a978-5fe327284a35_00000007-e627-f129-ac00-343a0d00b106"}}'
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
content-type:
- application/json; charset=utf-8
date:
- Tue, 22 Dec 2020 18:28:04 GMT
- Wed, 27 Jan 2021 23:55:48 GMT
ms-cv:
- /4JsXqUuEkmQ1v304iaBTw.0
- iocVB67Og0KRosYwvJnZlg.0
strict-transport-security:
- max-age=2592000
transfer-encoding:
- chunked
x-processing-time:
- 635ms
- 183ms
status:
code: 200
message: OK
code: 201
message: Created
version: 1
42 changes: 22 additions & 20 deletions ...cation-identity/tests/recordings/test_communication_identity_client.test_delete_user.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interactions:
- request:
body: null
body: '{}'
headers:
Accept:
- application/json
Expand All @@ -9,69 +9,71 @@ interactions:
Connection:
- keep-alive
Content-Length:
- '0'
- '2'
Content-Type:
- application/json
Date:
- Tue, 22 Dec 2020 18:29:13 GMT
- Wed, 27 Jan 2021 23:56:55 GMT
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
x-ms-return-client-request-id:
- 'true'
method: POST
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2021-03-07
response:
body:
string: '{"id": "sanitized"}'
string: '{"identity": {"id": "8:acs:b040bbd1-fb13-465b-a547-44c5ff20b980_00000007-e628-f9f8-3ef0-8b3a0d003d3d"}}'
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
content-type:
- application/json; charset=utf-8
date:
- Tue, 22 Dec 2020 18:29:12 GMT
- Wed, 27 Jan 2021 23:56:55 GMT
ms-cv:
- UzbbWyNM6Ee4hx1Ym7MwSA.0
- lv7eyX3+o0SgYHigmvhZNw.0
strict-transport-security:
- max-age=2592000
transfer-encoding:
- chunked
x-processing-time:
- 19ms
- 214ms
status:
code: 200
message: OK
code: 201
message: Created
- request:
body: null
headers:
Accept:
- '*/*'
- application/json
Accept-Encoding:
- gzip, deflate
Connection:
- keep-alive
Content-Length:
- '0'
Date:
- Tue, 22 Dec 2020 18:29:14 GMT
- Wed, 27 Jan 2021 23:56:55 GMT
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
x-ms-return-client-request-id:
- 'true'
method: DELETE
uri: https://communicationegrcrs.communication.azure.com/identities/sanitized?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities/sanitized?api-version=2021-03-07
response:
body:
string: ''
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
date:
- Tue, 22 Dec 2020 18:29:13 GMT
- Wed, 27 Jan 2021 23:56:56 GMT
ms-cv:
- bD8oBIuNQEWXEaluFwupbA.0
- sVJZF/hnPUiFLBDEQt3jnQ.0
strict-transport-security:
- max-age=2592000
x-processing-time:
- 764ms
- 777ms
status:
code: 204
message: No Content
Expand Down
38 changes: 20 additions & 18 deletions ...recordings/test_communication_identity_client.test_delete_user_from_managed_identity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interactions:
- request:
body: null
body: '{}'
headers:
Accept:
- application/json
Expand All @@ -9,61 +9,63 @@ interactions:
Connection:
- keep-alive
Content-Length:
- '0'
- '2'
Content-Type:
- application/json
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
method: POST
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities?api-version=2021-03-07
response:
body:
string: '{"id": "sanitized"}'
string: '{"identity": {"id": "8:acs:f050eca7-6baa-4427-966b-21841aa36a78_00000007-e62a-1f3f-8337-3b3a0d009555"}}'
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
content-type:
- application/json; charset=utf-8
date:
- Tue, 22 Dec 2020 18:30:23 GMT
- Wed, 27 Jan 2021 23:58:10 GMT
ms-cv:
- eSMH8ZATxUWO5OamG49Wdg.0
- RivzvSMrYUCxdpIjJOqXeA.0
strict-transport-security:
- max-age=2592000
transfer-encoding:
- chunked
x-processing-time:
- 811ms
- 193ms
status:
code: 200
message: OK
code: 201
message: Created
- request:
body: null
headers:
Accept:
- '*/*'
- application/json
Accept-Encoding:
- gzip, deflate
Connection:
- keep-alive
Content-Length:
- '0'
User-Agent:
- azsdk-python-communication-identity/1.0.0b4 Python/3.8.5 (Windows-10-10.0.19041-SP0)
- azsdk-python-communication-identity/1.0.0b4 Python/3.9.0 (Windows-10-10.0.19041-SP0)
method: DELETE
uri: https://communicationegrcrs.communication.azure.com/identities/sanitized?api-version=2020-07-20-preview2
uri: https://communicationegrcrs.communication.azure.com/identities/sanitized?api-version=2021-03-07
response:
body:
string: ''
headers:
api-supported-versions:
- 2020-01-15-preview3, 2020-07-20-preview1, 2020-07-20-preview2
- 2020-07-20-preview2, 2021-03-07
date:
- Tue, 22 Dec 2020 18:30:24 GMT
- Wed, 27 Jan 2021 23:58:12 GMT
ms-cv:
- 91lJNqPMP0+hZnY0ay0tXA.0
- akcIQiMeskOt/X1QZdhizg.0
strict-transport-security:
- max-age=2592000
x-processing-time:
- 741ms
- 1936ms
status:
code: 204
message: No Content
Expand Down
Loading