Conversation
There was a problem hiding this comment.
These changes look acceptable, though I'll say to @ktlim right now that this reinforces my opinion that 79 characters is a bad idea for our Python code due to decreased readability.
I also agree with @jonathansick that autopep8 is not good enough to use for automatic reformatting of all our code (unlike clang-format, which is basically always good enough). The one small saving grace to autopep8 is that it leaves already compliant lines alone, so at least we can fix the most egregious problems and they will stay fixed (unlike clang-format, which always reformats code). Still, the thought of turning it loose on our entire stack makes me shudder.
|
I think we can probably close this without merging? |
|
Yes. The docstrings and comments will need to be shortened but we'll have to redo those later. We really want PyCQA/pycodestyle#674 to be merged. |
|
Abandon this. We will stick with 110 for code and 79 for docstrings now that pycodestyle has accepted our patch. |
This commit implements RFC-107 for the utils package. The good news is that autopep8 does work. The bad news is that:
Therefore these commits are about 30% automated and the rest manual.