DM-49497: Add check for valid BFK #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
Mar 19, 2025
python/lsst/cp/pipe/cpBfk.py
Outdated
| # Edges should converge to zero | ||
| valid = np.all(np.isclose(kernelEdges, 0, rtol=5*kernelEdgeStd)) | ||
| # Kernel should be negative | ||
| valid = np.all(bfk.ampKernels[ampName] <= 5*kernelEdgeStd) |
There was a problem hiding this comment.
Yep! Thanks :)
python/lsst/cp/pipe/cpBfk.py
Outdated
| xv, yv = np.meshgrid(range(kernelSize), range(kernelSize)) | ||
| # Get a mask for a 3px picture frame | ||
| valid = True | ||
| if kernelSize >= 7: |
There was a problem hiding this comment.
Should any of this be configurable (the 3x3, the 7 size, the 5 times std) or you think these are fixed-fixed?
There was a problem hiding this comment.
The 5 sigma can be a config, but the 3px shouldn't be. The kernel should be just big enough to have 3 px on the edge that go to zero. 7 is then just the minimum size (3*2 + 1)
Alex-Broughton
force-pushed
the
tickets/DM-49497
branch
2 times, most recently
from
0a3f7ac to
3669bfb
Compare
erykoff
reviewed
Mar 19, 2025
Alex-Broughton
force-pushed
the
tickets/DM-49497
branch
3 times, most recently
from
67e8d63 to
b12f6de
Compare
erykoff
requested changes
Mar 19, 2025
Alex-Broughton
force-pushed
the
tickets/DM-49497
branch
from
b12f6de to
ccca598
Compare
Alex-Broughton
force-pushed
the
tickets/DM-49497
branch
from
ccca598 to
fb3776c
Compare
erykoff
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.