-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream implementation of native bindings #44
Conversation
@eelcocramer any time lines on fixing issue #45 ? |
May also fix #48. |
@eelcocramer , can you fork this repo to your account and do the changes there so it can be used? |
@frankjoke the forked repo is already there. This PR originates from there. You can find the link below the title where it says |
Ok, I tried this and could not load it, got
p.s.: I am not in in writing/managing nodejs code with bindings and C++ therefore I doi not kinow exactly what is needed there. I am mainly writin web apps or home automation adapters and tools. |
Well, I'm not going to publish it. But you can fork it and publish it yourself if you need it. |
I tried this and managed after a view changes to your install script to get a module which could be installed on multiple systems. Youi can find it here https://github.com/frankjoke/node-bluetooth and it's npm is @frankjoke/node-bluetooth. |
Feedback also welcome at |
For the convenience of folks that use the javascript patterns used in @song940's module I've updated my PR to use the experimental C sources from my fix branch. So you can now use my fork of his repo to verify if these fixes work. I don't think the inquiry functions work but for some folks reading and writing may be fine. Feedback is appreciated! |
I notice that a lot of your current problems have already been fixed in the upstream module, which I maintain, and where you copied the sources from.
This PR makes you module depend on the upstream module so you are always using the latest sources and allow you to focus on maintaining your own javascript bindings.