Simplify test_combine_echodata_combined_append #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code for repeated blocks; plus other readability tweaks
lsetiawan
added a commit
to OSOceanAcoustics/echopype
that referenced
this pull request
Aug 15, 2023
* fix: fix how provenance data are combined * test: add test to check actual prov vals * fix: remove ECHODATA_FILENAME, use ED_FILENAME * tests: simplify 'test_combine_echodata_combined_append' (lsetiawan#1) Simplified by using common code for repeated blocks; plus other readability tweaks --------- Co-authored-by: Emilio Mayorga <[email protected]> Refs: #1115
lsetiawan
pushed a commit
that referenced
this pull request
Sep 20, 2023
…parsers. (OSOceanAcoustics#1135) * replaced usage of xml.dom.minidom with xml.etree.ElementTree * modified azfp parser and parsed all parameters * refactored the parse_azfp code and added new tests * small tweak in test, rename conversion function to _camel_to_snake * updated parameter names * Replace camel-to-snake conversion funcitonality (#1) * Create utils camel-to-snake-case function in new misc.py, and use it in ek_raw_parsers * Replace AZFP camel-to-snake function with new utils/misc.py function * fixed minor error in code * minor change in test_convert_azfp.py * fixed failing tests * fixed failing tests related to attribute name * fixed minor bug --------- Co-authored-by: Wu-Jung Lee <[email protected]> Co-authored-by: Emilio Mayorga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_combine_echodata_combined_append, esp. by using common code for repeated blocks; plus other readability tweakscombine.pydocstring