Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rackup server #1607

Closed
wants to merge 3 commits into from
Closed

Remove rackup server #1607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c5de51
Add rackup for specs
xjunior Feb 25, 2025
4864dbe
Use Rack::Server in Yard::Server::RackAdapter
xjunior Feb 25, 2025
7e34b27
Remove now unnecessary dependency
xjunior Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions lib/yard/server/rack_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@
# frozen_string_literal: true

require 'rack'

module YARD
module Server
begin
require 'rackup'
# @private
RackServer = Rackup::Server
rescue LoadError
require 'rack'
# @private
RackServer = Rack::Server
end

# This class wraps the {RackAdapter} into a Rack-compatible middleware.
# See {#initialize} for a list of options to pass via Rack's +#use+ method.
#
Expand Down Expand Up @@ -68,7 +60,7 @@ def call(env)
# block.
# @return [void]
def start
server = RackServer.new(server_options)
server = Rack::Server.new(server_options)
server.instance_variable_set("@app", self)
print_start_message(server)
server.start
Expand Down
Loading