Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tilde (~) expansion on windows #999

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Mar 1, 2024

No description provided.

@zwpaper zwpaper requested review from meain and Peltoche as code owners March 1, 2024 15:59
Copy link

muniu-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zwpaper

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 51.78571% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 84.45%. Comparing base (e9a778a) to head (999ae06).
Report is 1 commits behind head on master.

Files Patch % Lines
src/config_file.rs 34.48% 19 Missing ⚠️
src/theme.rs 79.16% 5 Missing ⚠️
src/core.rs 0.00% 2 Missing ⚠️
src/meta/date.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   84.63%   84.45%   -0.19%     
==========================================
  Files          53       53              
  Lines        5078     5108      +30     
==========================================
+ Hits         4298     4314      +16     
- Misses        780      794      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwpaper zwpaper force-pushed the windows-fixes-pr branch from 93cab01 to bbc5937 Compare March 9, 2024 16:39
Signed-off-by: Wei Zhang <[email protected]>
@zwpaper zwpaper force-pushed the windows-fixes-pr branch from bbc5937 to 3b3b328 Compare March 9, 2024 17:24
@muniu-bot muniu-bot bot added size/L and removed size/XXL labels Mar 9, 2024
Signed-off-by: Wei Zhang <[email protected]>
will fix in next release

Signed-off-by: Wei Zhang <[email protected]>
@zwpaper zwpaper merged commit 4310bf8 into lsd-rs:master Mar 22, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants