-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog deprecation notice #907
Conversation
The pull request template still mentions that a changelog entry should be added. Should I remove it? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shilangyu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,4 +1,7 @@ | |||
# Changelog | |||
|
|||
NOTE: This file is no longer being updated. For release notes follow [GitHub releases](https://github.com/lsd-rs/lsd/releases). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by saying GitHub auto-generates release notes, I mean https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
We don't have to update this file and will generate by PRs when releasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you would like me to do here. I understand what you are trying to achieve, but not what is the future of this CHANGELOG file. What should the notice say? If there should be a notice at all?
can you also help drop this line: https://github.com/lsd-rs/lsd/blob/master/.github/PULL_REQUEST_TEMPLATE#L9 |
Created out of: #900 (comment)