Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog deprecation notice #907

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Add changelog deprecation notice #907

merged 2 commits into from
Sep 23, 2023

Conversation

shilangyu
Copy link
Contributor

Created out of: #900 (comment)

@shilangyu
Copy link
Contributor Author

The pull request template still mentions that a changelog entry should be added. Should I remove it?

@muniu-bot
Copy link

muniu-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shilangyu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,4 +1,7 @@
# Changelog

NOTE: This file is no longer being updated. For release notes follow [GitHub releases](https://github.com/lsd-rs/lsd/releases).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by saying GitHub auto-generates release notes, I mean https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

We don't have to update this file and will generate by PRs when releasing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you would like me to do here. I understand what you are trying to achieve, but not what is the future of this CHANGELOG file. What should the notice say? If there should be a notice at all?

@zwpaper
Copy link
Member

zwpaper commented Sep 21, 2023

@zwpaper zwpaper merged commit 949128f into lsd-rs:master Sep 23, 2023
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants