Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1052 fix lsd pipe output #1059

Merged
merged 5 commits into from
Aug 19, 2024
Merged

#1052 fix lsd pipe output #1059

merged 5 commits into from
Aug 19, 2024

Conversation

WangMengabc
Copy link
Contributor

@WangMengabc WangMengabc commented Jun 13, 2024


TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@WangMengabc WangMengabc requested a review from zwpaper as a code owner June 13, 2024 01:42
@muniu-bot muniu-bot bot added the size/XS label Jun 21, 2024
@GottZ
Copy link

GottZ commented Jul 13, 2024

closes #1072

Copy link

muniu-bot bot commented Jul 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GottZ, WangMengabc
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GottZ
Copy link

GottZ commented Jul 13, 2024

@meain hey there. can you please take a look at this, as @zwpaper seems to be on vacation off github for a month by now?

@zwpaper
Copy link
Member

zwpaper commented Jul 17, 2024

sorry for the delay, some personal issues have trapped me recently. I will look into PRs in following days

@GottZ
Copy link

GottZ commented Aug 2, 2024

sorry for the delay, some personal issues have trapped me recently.

welcome back!

@zwpaper
Copy link
Member

zwpaper commented Aug 11, 2024

the change lgtm, but we may have some issues on tests, I am working on it, and will merge after I fix the tests

@GottZ
Copy link

GottZ commented Aug 17, 2024

I'm at FrOSCon right now, lsd just got presented at a talk where I just had to mention this bug.

@zwpaper
Copy link
Member

zwpaper commented Aug 17, 2024

Hi @GottZ, thanks so much for provide the info about the talk, it was excited to know about people using lsd.

as for the bug, I beleive this PR has fix it and it should be good to go now, can you hekp checking the lsd from https://github.com/WangMengabc/lsd/tree/master, or I can build a binary for you if needed.

@GottZ
Copy link

GottZ commented Aug 18, 2024

as for the bug, I beleive this PR has fix it and it should be good to go now, can you hekp checking the lsd from https://github.com/WangMengabc/lsd/tree/master, or I can build a binary for you if needed.

image

it's flawless. thanks!

@zwpaper zwpaper merged commit a7fce64 into lsd-rs:master Aug 19, 2024
17 of 19 checks passed
@zwpaper
Copy link
Member

zwpaper commented Aug 19, 2024

thanks for the help, let's create a new release for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants