Skip to content

fix: send session cancel for active turns - #30

Merged
lsaether merged 1 commit into
mainfrom
fix/issue-29-active-turn-session-cancel
May 24, 2026
Merged

lsaether merged 1 commit into
mainfrom
fix/issue-29-active-turn-session-cancel

Conversation

@lsaether

Copy link
Copy Markdown
Owner

Summary

  • send ACP-native session/cancel { sessionId } for amux/cancel_active_turn instead of synthesizing $/cancel_request
  • track the active prompt's upstream ACP session id so cross-peer cancellation reaches Hermes' interrupt path
  • update cancellation docs and mock ACP test support for session/cancel

Fixes #29.

Test plan

  • cargo test amux_cancel_active_turn -- --nocapture
  • cargo fmt --check
  • cargo test
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@lsaether
lsaether merged commit e52cfeb into main May 24, 2026
1 check passed
@lsaether
lsaether deleted the fix/issue-29-active-turn-session-cancel branch May 24, 2026 18:39
lsaether added a commit that referenced this pull request May 27, 2026
Cuts v0.1.3 — rooms + RFD #533 attach polish.

Highlights since v0.1.2:
- Rooms abstraction with compaction-aware transcripts (#58) and
  cross-segment turn-bookend carry in historyPolicy: full (#59).
  Closes #56.
- RFD #533-inspired session/attach + session/detach foundation (#46)
  with replay ordering (#47), streamed history delivery (#53), and
  ?replay=skip opt-out for attach-aware clients (#50).
- amux/* active-turn controls (steer #41, queue #41, cancel #30)
  plus replay-safe agent request lifecycle openings (#33).
- Safe-by-default client-tool blocking (fs/* + terminal/*) with
  --unsafe-debug-client-tool-broadcast escape hatch (#36).
- amux/session_context surfaces the mux/agent cwd to subscribers (#35).

Validation:
- cargo fmt --check
- cargo clippy --all-targets -- -D warnings
- cargo test (63 unit + 78 integration = 141 tests)

Co-authored-by: lsaether <25539605+lsaether@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

amux/cancel_active_turn should trigger ACP session/cancel for Hermes turns

1 participant