-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Change client builder from browser esbuild to application
#8204
Conversation
Development
: Switch from browser-esbuild to application as production builderDevelopment
: Change production builder from browser-esbuild to application
Development
: Change production builder from browser-esbuild to applicationDevelopment
: Change client builder from browser-esbuild to application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work as expected, tested both locally and on ts3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, client does not break works well
Development
: Change client builder from browser-esbuild to applicationDevelopment
: Change client builder from browser esbuild to application
Checklist
General
Motivation and Context
In #6546, during the switch to Angular 16, we changed the production builder to
browser-esbuild
. This builder's schema lacks theloader
option that will be required to integrate the Monaco editor into Artemis (#8130). By switching to the preferredapplication
builder (that also uses esbuild), this becomes possible.Description
The changes follow the instructions for migrating to the application builder.
Since SSR does not affect us, I have configured the
outputPath
property to output to the same directory as before (setsoutputPath.browser
to""
- see also this issue in the Angular repository)Steps for Testing
Verify that Artemis can still be deployed to a test server and that the client does not break.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests