Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Change client builder from browser esbuild to application #8204

Merged
merged 5 commits into from
Mar 23, 2024

Conversation

pzdr7
Copy link
Contributor

@pzdr7 pzdr7 commented Mar 15, 2024

Checklist

General

Motivation and Context

In #6546, during the switch to Angular 16, we changed the production builder to browser-esbuild. This builder's schema lacks the loader option that will be required to integrate the Monaco editor into Artemis (#8130). By switching to the preferred application builder (that also uses esbuild), this becomes possible.

Description

The changes follow the instructions for migrating to the application builder.

Since SSR does not affect us, I have configured the outputPath property to output to the same directory as before (sets outputPath.browser to "" - see also this issue in the Angular repository)

Steps for Testing

Verify that Artemis can still be deployed to a test server and that the client does not break.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@pzdr7 pzdr7 self-assigned this Mar 15, 2024
@pzdr7 pzdr7 temporarily deployed to artemis-test2.artemis.cit.tum.de March 15, 2024 10:58 — with GitHub Actions Inactive
@pzdr7 pzdr7 changed the title Development: Switch from browser-esbuild to application as production builder Development: Change production builder from browser-esbuild to application Mar 15, 2024
@pzdr7 pzdr7 marked this pull request as ready for review March 15, 2024 11:14
@pzdr7 pzdr7 requested a review from a team as a code owner March 15, 2024 11:14
@pzdr7 pzdr7 changed the title Development: Change production builder from browser-esbuild to application Development: Change client builder from browser-esbuild to application Mar 18, 2024
Copy link
Contributor

@dmytropolityka dmytropolityka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected, tested both locally and on ts3

Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me 👍

Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration looks good to me

Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, client does not break works well

@krusche krusche added this to the 7.0.0 milestone Mar 23, 2024
@krusche krusche changed the title Development: Change client builder from browser-esbuild to application Development: Change client builder from browser esbuild to application Mar 23, 2024
@krusche krusche merged commit d6f846b into develop Mar 23, 2024
29 of 34 checks passed
@krusche krusche deleted the development/application-builder branch March 23, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants